[llvm-commits] CVS: nightlytest-serverside/ProgramResults.php fulltest.php test.php

[Jim Laskey]

Changes in directory nightlytest-serverside:

ProgramResults.php updated: 1.31 -> 1.32
fulltest.php updated: 1.16 -> 1.17
test.php updated: 1.18 -> 1.19
---
Log message:

Clean up.


---
Diffs of the changes:  (+8 -6)

 ProgramResults.php |    8 +++++---
 fulltest.php       |    2 +-
 test.php           |    4 ++--
 3 files changed, 8 insertions(+), 6 deletions(-)


Index: nightlytest-serverside/ProgramResults.php
diff -u nightlytest-serverside/ProgramResults.php:1.31 nightlytest-serverside/ProgramResults.php:1.32
--- nightlytest-serverside/ProgramResults.php:1.31	Thu Aug 31 13:44:47 2006
+++ nightlytest-serverside/ProgramResults.php	Fri Sep  1 05:48:04 2006
@@ -436,7 +436,7 @@
  * This is somewhat of a hack because from night 684 forward we now store the test 
  * in their own table as oppoesd in the night table.
  */
-function getUnexpectedFailures($night_id, $mysql_link){
+function getUnexpectedFailures($night_id){
   $result="";
   if($night_id<$new_schema_id){
     $query = "SELECT unexpfail_tests FROM night WHERE id = $night_id";
@@ -554,10 +554,12 @@
 /*
  * Does the test pass
  *
- * Return true if the test result indicates a pass.
+ * Return true if the test result indicates a pass.  For "tests" the possible
+ * conditions are "PASS", "FAIL" and "XFAIL" (expected to fail.)  For programs
+ * an asterix appears by each tool that has failed.
  */
 function isTestPass($test_result) {
-  return strcmp($test_result, "PASS") === 0 ||
+  return strcmp($test_result, "FAIL") != 0 ||
          strpos($test_result, "*") === false;
 }
 


Index: nightlytest-serverside/fulltest.php
diff -u nightlytest-serverside/fulltest.php:1.16 nightlytest-serverside/fulltest.php:1.17
--- nightlytest-serverside/fulltest.php:1.16	Thu Aug 31 13:10:50 2006
+++ nightlytest-serverside/fulltest.php	Fri Sep  1 05:48:04 2006
@@ -200,7 +200,7 @@
 $delta_exppass = $today_row['teststats_exppass']-$yesterday_row['teststats_exppass'];
 $delta_expfail = $today_row['teststats_expfail']-$yesterday_row['teststats_expfail'];
 $delta_unexpfail = $today_row['teststats_unexpfail']-$yesterday_row['teststats_unexpfail'];
-$unexpected_failures = getUnexpectedFailures($night_id, $mysql_link);
+$unexpected_failures = getUnexpectedFailures($night_id);
 
 if($delta_exppass==0 && $delta_expfail==0 && 
    $delta_unexpfail==0 && strcmp($unexpected_failures, "")===0){


Index: nightlytest-serverside/test.php
diff -u nightlytest-serverside/test.php:1.18 nightlytest-serverside/test.php:1.19
--- nightlytest-serverside/test.php:1.18	Mon Aug 21 16:56:57 2006
+++ nightlytest-serverside/test.php	Fri Sep  1 05:48:04 2006
@@ -191,7 +191,7 @@
  * Printing failures in test suite
  *
  ******************************************************/
-$failing_tests=getFailures($night_id, $previous_succesful_id, $mysql_link);
+$failing_tests=getFailures($night_id);
 if(strcmp($failing_tests,"")===0){
   $newly_failing_tests="None";
 }
@@ -212,7 +212,7 @@
 $delta_exppass = $today_row['teststats_exppass']-$yesterday_row['teststats_exppass'];
 $delta_expfail = $today_row['teststats_expfail']-$yesterday_row['teststats_expfail'];
 $delta_unexpfail = $today_row['teststats_unexpfail']-$yesterday_row['teststats_unexpfail'];
-$unexpected_failures = getUnexpectedFailures($night_id, $mysql_link);
+$unexpected_failures = getUnexpectedFailures($night_id);
 
 if($delta_exppass==0 && $delta_expfail==0 && 
    $delta_unexpfail==0 && strcmp($unexpected_failures,"")===0){