[llvm-commits] CVS: llvm/include/llvm/ValueSymbolTable.h TypeSymbolTable.h SymbolTable.h

[Reid Spencer]

Wouldn't uint32_t be sufficient for these? I can't see anyone having
more than 4 billion name collisions. And it reduce a little arithmetic
cost on 32-bit platforms.

Reid.

On Wed, 2006-05-31 at 15:18 -0500, Andrew Lenharth wrote:
> Log message:
> 
> Fix build breakage on alpha, without causing it on x86.  as a bonus, all platforms can invent the same number of unique names now
> Index: llvm/include/llvm/ValueSymbolTable.h
> diff -u llvm/include/llvm/ValueSymbolTable.h:1.1 llvm/include/llvm/ValueSymbolTable.h:1.2
> --- llvm/include/llvm/ValueSymbolTable.h:1.1	Tue Jan 10 03:51:48 2006
> +++ llvm/include/llvm/ValueSymbolTable.h	Wed May 31 15:18:28 2006
> @@ -127,7 +127,7 @@
>  /// @{
>  private:
>    ValueMap vmap;                    ///< The map that holds the symbol table.
> -  mutable unsigned long LastUnique; ///< Counter for tracking unique names
> +  mutable uint64_t LastUnique; ///< Counter for tracking unique names
>  

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20060531/5cac8db7/attachment.sig>