[llvm-commits] CVS: llvm/lib/Target/X86/X86ISelLowering.cpp

[Evan Cheng]

Changes in directory llvm/lib/Target/X86:

X86ISelLowering.cpp updated: 1.166 -> 1.167
---
Log message:

Do not use movs{h|l}dup for a shuffle with a single non-undef node.

---
Diffs of the changes:  (+14 -2)

 X86ISelLowering.cpp |   16 ++++++++++++++--
 1 files changed, 14 insertions(+), 2 deletions(-)


Index: llvm/lib/Target/X86/X86ISelLowering.cpp
diff -u llvm/lib/Target/X86/X86ISelLowering.cpp:1.166 llvm/lib/Target/X86/X86ISelLowering.cpp:1.167
--- llvm/lib/Target/X86/X86ISelLowering.cpp:1.166	Fri Apr 14 16:59:03 2006
+++ llvm/lib/Target/X86/X86ISelLowering.cpp	Fri Apr 14 22:13:24 2006
@@ -1724,12 +1724,14 @@
     return false;
 
   // Expect 1, 1, 3, 3
+  unsigned NumNodes = 0;
   for (unsigned i = 0; i < 2; ++i) {
     SDOperand Arg = N->getOperand(i);
     if (Arg.getOpcode() == ISD::UNDEF) continue;
     assert(isa<ConstantSDNode>(Arg) && "Invalid VECTOR_SHUFFLE mask!");
     unsigned Val = cast<ConstantSDNode>(Arg)->getValue();
     if (Val != 1) return false;
+    NumNodes++;
   }
   for (unsigned i = 2; i < 4; ++i) {
     SDOperand Arg = N->getOperand(i);
@@ -1737,8 +1739,12 @@
     assert(isa<ConstantSDNode>(Arg) && "Invalid VECTOR_SHUFFLE mask!");
     unsigned Val = cast<ConstantSDNode>(Arg)->getValue();
     if (Val != 3) return false;
+    NumNodes++;
   }
-  return true;
+
+  // Don't use movshdup if the resulting vector contains only one undef node.
+  // Use {p}shuf* instead.
+  return NumNodes > 1;
 }
 
 /// isMOVSLDUPMask - Return true if the specified VECTOR_SHUFFLE operand
@@ -1750,12 +1756,14 @@
     return false;
 
   // Expect 0, 0, 2, 2
+  unsigned NumNodes = 0;
   for (unsigned i = 0; i < 2; ++i) {
     SDOperand Arg = N->getOperand(i);
     if (Arg.getOpcode() == ISD::UNDEF) continue;
     assert(isa<ConstantSDNode>(Arg) && "Invalid VECTOR_SHUFFLE mask!");
     unsigned Val = cast<ConstantSDNode>(Arg)->getValue();
     if (Val != 0) return false;
+    NumNodes++;
   }
   for (unsigned i = 2; i < 4; ++i) {
     SDOperand Arg = N->getOperand(i);
@@ -1763,8 +1771,12 @@
     assert(isa<ConstantSDNode>(Arg) && "Invalid VECTOR_SHUFFLE mask!");
     unsigned Val = cast<ConstantSDNode>(Arg)->getValue();
     if (Val != 2) return false;
+    NumNodes++;
   }
-  return true;
+
+  // Don't use movsldup if the resulting vector contains only one undef node.
+  // Use {p}shuf* instead.
+  return NumNodes > 1;
 }
 
 /// isSplatMask - Return true if the specified VECTOR_SHUFFLE operand specifies