[llvm-commits] CVS: llvm/lib/Target/X86/X86ISelLowering.cpp X86InstrSSE.td

[Evan Cheng]

Changes in directory llvm/lib/Target/X86:

X86ISelLowering.cpp updated: 1.143 -> 1.144
X86InstrSSE.td updated: 1.43 -> 1.44
---
Log message:

Need to special case splat after all. Make the second operand of splat
vector_shuffle undef.


---
Diffs of the changes:  (+18 -15)

 X86ISelLowering.cpp |   16 ++++++++--------
 X86InstrSSE.td      |   17 ++++++++++-------
 2 files changed, 18 insertions(+), 15 deletions(-)


Index: llvm/lib/Target/X86/X86ISelLowering.cpp
diff -u llvm/lib/Target/X86/X86ISelLowering.cpp:1.143 llvm/lib/Target/X86/X86ISelLowering.cpp:1.144
--- llvm/lib/Target/X86/X86ISelLowering.cpp:1.143	Tue Mar 28 21:04:49 2006
+++ llvm/lib/Target/X86/X86ISelLowering.cpp	Wed Mar 29 13:02:40 2006
@@ -2397,21 +2397,21 @@
     MVT::ValueType VT = Op.getValueType();
     unsigned NumElems = PermMask.getNumOperands();
 
-    if (X86::isUNPCKLMask(PermMask.Val) ||
-        X86::isUNPCKHMask(PermMask.Val))
-      // Leave the VECTOR_SHUFFLE alone. It matches {P}UNPCKL*.
-      return SDOperand();
-
-    // PSHUFD's 2nd vector must be undef.
-    if (MVT::isInteger(VT) && X86::isPSHUFDMask(PermMask.Val)) {
+    // Splat && PSHUFD's 2nd vector must be undef.
+    if (X86::isSplatMask(PermMask.Val) ||
+        ((MVT::isInteger(VT) && X86::isPSHUFDMask(PermMask.Val)))) {
       if (V2.getOpcode() != ISD::UNDEF)
         return DAG.getNode(ISD::VECTOR_SHUFFLE, VT, V1,
                            DAG.getNode(ISD::UNDEF, V1.getValueType()),PermMask);
       return SDOperand();
     }
 
+    if (X86::isUNPCKLMask(PermMask.Val) ||
+        X86::isUNPCKHMask(PermMask.Val))
+      // Leave the VECTOR_SHUFFLE alone. It matches {P}UNPCKL*.
+      return SDOperand();
+
     if (NumElems == 2 ||
-        X86::isSplatMask(PermMask.Val) ||
         X86::isSHUFPMask(PermMask.Val)) {
       return NormalizeVectorShuffle(V1, V2, PermMask, VT, DAG);
     }


Index: llvm/lib/Target/X86/X86InstrSSE.td
diff -u llvm/lib/Target/X86/X86InstrSSE.td:1.43 llvm/lib/Target/X86/X86InstrSSE.td:1.44
--- llvm/lib/Target/X86/X86InstrSSE.td:1.43	Wed Mar 29 12:47:40 2006
+++ llvm/lib/Target/X86/X86InstrSSE.td	Wed Mar 29 13:02:40 2006
@@ -58,9 +58,9 @@
   return getI8Imm(X86::getShuffleSHUFImmediate(N));
 }]>;
 
-def v2f64_v2i64_splat_mask : PatLeaf<(build_vector), [{
+def SSE_splat_mask : PatLeaf<(build_vector), [{
   return X86::isSplatMask(N);
-}]>;
+}], SHUFFLE_get_shuf_imm>;
 
 def MOVLHPS_shuffle_mask : PatLeaf<(build_vector), [{
   return X86::isMOVLHPSMask(N);
@@ -1375,13 +1375,16 @@
           (MOVZD128rr (V_SET0_PI), (MOVZX32rr8 R8:$src))>, Requires<[HasSSE2]>;
 
 // Splat v2f64 / v2i64
-def : Pat<(vector_shuffle (v2f64 VR128:$src), (v2f64 VR128:$src),
-           v2f64_v2i64_splat_mask:$sm),
-          (v2f64 (UNPCKLPDrr VR128:$src, VR128:$src))>, Requires<[HasSSE2]>;
-def : Pat<(vector_shuffle (v2i64 VR128:$src), (v2i64 VR128:$src),
-           v2f64_v2i64_splat_mask:$sm),
+def : Pat<(vector_shuffle (v2f64 VR128:$src), (undef), SSE_splat_mask:$sm),
+          (v2f64 (UNPCKLPDrr VR128:$src, VR128:$src))>,   Requires<[HasSSE2]>;
+def : Pat<(vector_shuffle (v2i64 VR128:$src), (undef), SSE_splat_mask:$sm),
           (v2i64 (PUNPCKLQDQrr VR128:$src, VR128:$src))>, Requires<[HasSSE2]>;
 
+// Splat v4f32
+def : Pat<(vector_shuffle (v4f32 VR128:$src), (undef), SSE_splat_mask:$sm),
+          (v4f32 (SHUFPSrr VR128:$src, VR128:$src, SSE_splat_mask:$sm))>,
+      Requires<[HasSSE1]>;
+
 // Shuffle v4i32 if others do not match
 def : Pat<(vector_shuffle (v4i32 VR128:$src1), (v4i32 VR128:$src2),
            SHUFP_shuffle_mask:$sm),