[llvm-commits] CVS: llvm/utils/TableGen/CodeGenIntrinsics.h IntrinsicEmitter.cpp

[Chris Lattner]

Changes in directory llvm/utils/TableGen:

CodeGenIntrinsics.h updated: 1.3 -> 1.4
IntrinsicEmitter.cpp updated: 1.6 -> 1.7
---
Log message:

Verify that packed type operands have the right size and base type.


---
Diffs of the changes:  (+28 -6)

 CodeGenIntrinsics.h  |    4 ++++
 IntrinsicEmitter.cpp |   30 ++++++++++++++++++++++++------
 2 files changed, 28 insertions(+), 6 deletions(-)


Index: llvm/utils/TableGen/CodeGenIntrinsics.h
diff -u llvm/utils/TableGen/CodeGenIntrinsics.h:1.3 llvm/utils/TableGen/CodeGenIntrinsics.h:1.4
--- llvm/utils/TableGen/CodeGenIntrinsics.h:1.3	Thu Mar  9 16:05:04 2006
+++ llvm/utils/TableGen/CodeGenIntrinsics.h	Mon Mar 13 16:38:57 2006
@@ -30,6 +30,10 @@
     /// of the arguments.  These are things like Type::UIntTyID.
     std::vector<std::string> ArgTypes;
     
+    /// ArgTypeDefs - The records for each argument type.
+    ///
+    std::vector<Record*> ArgTypeDefs;
+    
     // Memory mod/ref behavior of this intrinsic.
     enum {
       NoMem, ReadArgMem, ReadMem, WriteArgMem, WriteMem


Index: llvm/utils/TableGen/IntrinsicEmitter.cpp
diff -u llvm/utils/TableGen/IntrinsicEmitter.cpp:1.6 llvm/utils/TableGen/IntrinsicEmitter.cpp:1.7
--- llvm/utils/TableGen/IntrinsicEmitter.cpp:1.6	Fri Mar 10 18:20:47 2006
+++ llvm/utils/TableGen/IntrinsicEmitter.cpp	Mon Mar 13 16:38:57 2006
@@ -13,6 +13,7 @@
 
 #include "IntrinsicEmitter.h"
 #include "Record.h"
+#include "llvm/ADT/StringExtras.h"
 using namespace llvm;
 
 //===----------------------------------------------------------------------===//
@@ -52,6 +53,7 @@
     Record *TyEl = DI->getDef();
     assert(TyEl->isSubClassOf("LLVMType") && "Expected a type!");
     ArgTypes.push_back(TyEl->getValueAsString("TypeVal"));
+    ArgTypeDefs.push_back(TyEl);
   }
   if (ArgTypes.size() == 0)
     throw "Intrinsic '"+DefName+"' needs at least a type for the ret value!";
@@ -151,6 +153,25 @@
   OS << "#endif\n\n";
 }
 
+static void EmitTypeVerify(std::ostream &OS, const std::string &Val,
+                           Record *ArgType) {
+  OS << "    Assert1(" << Val << "->getTypeID() == "
+     << ArgType->getValueAsString("TypeVal") << ",\n"
+     << "            \"Illegal intrinsic type!\", IF);\n";
+
+  // If this is a packed type, check that the subtype and size are correct.
+  if (ArgType->isSubClassOf("LLVMPackedType")) {
+    Record *SubType = ArgType->getValueAsDef("ElTy");
+    OS << "    Assert1(cast<PackedType>(" << Val
+       << ")->getElementType()->getTypeID() == "
+       << SubType->getValueAsString("TypeVal") << ",\n"
+       << "            \"Illegal intrinsic type!\", IF);\n";
+    OS << "    Assert1(cast<PackedType>(" << Val << ")->getNumElements() == "
+       << ArgType->getValueAsInt("NumElts") << ",\n"
+       << "            \"Illegal intrinsic type!\", IF);\n";
+  }
+}
+
 void IntrinsicEmitter::EmitVerifier(const std::vector<CodeGenIntrinsic> &Ints, 
                                     std::ostream &OS) {
   OS << "// Verifier::visitIntrinsicFunctionCall code.\n";
@@ -163,13 +184,10 @@
     OS << "    Assert1(FTy->getNumParams() == " << Ints[i].ArgTypes.size()-1
        << ",\n"
        << "            \"Illegal # arguments for intrinsic function!\", IF);\n";
-    OS << "    Assert1(FTy->getReturnType()->getTypeID() == "
-       << Ints[i].ArgTypes[0] << ",\n"
-       << "            \"Illegal result type!\", IF);\n";
+    EmitTypeVerify(OS, "FTy->getReturnType()", Ints[i].ArgTypeDefs[0]);
     for (unsigned j = 1; j != Ints[i].ArgTypes.size(); ++j)
-      OS << "    Assert1(FTy->getParamType(" << j-1 << ")->getTypeID() == "
-         << Ints[i].ArgTypes[j] << ",\n"
-         << "            \"Illegal argument type!\", IF);\n";
+      EmitTypeVerify(OS, "FTy->getParamType(" + utostr(j-1) + ")",
+                     Ints[i].ArgTypeDefs[j]);
     OS << "    break;\n";
   }
   OS << "  }\n";