[llvm-commits] CVS: llvm/autoconf/configure.ac

[duraid at octopus.com.au]

> On Tue, 14 Feb 2006, Reid Spencer wrote:
>> Rather than just kill this checking, I would prefer it if the aCC
>> compiler was added to the check for supported compilers. This
>> configuration check (that you've deleted) can prevent really bad things
>> happening downstream.

Not trying to be picky, but what kind of really bad things are we talking
about? The worst thing I can imagine is that a build fails because there's
some issue between the source/makefiles and the user's toolchain.

> FWIW, I agree with reid.

I did ask..! :) For now, I'll just revert it and add aCC-specific stuff
later (the get-rid-of-hash-tables patch is still to come) but the
intention was that with a little bit of work LLVM could be made and kept
standard-compliant and so "any good compiler" should work, in theory.
Should we insist on known-good compilers, abort on known-bad compilers,
spit out scary warning messages, or something else again?

Anyway, for now I'll just revert this. Sorry guys! :)

       Duraid


> -Chris
>
>> On Tue, 2006-02-14 at 21:16 -0600, Duraid Madina wrote:
>>>
>>> Changes in directory llvm/autoconf:
>>>
>>> configure.ac updated: 1.207 -> 1.208
>>> ---
>>> Log message:
>>>
>>> previously, configure would die if GCC or ICC was not found. Now it'll
>>> go through, but we do want to know if we're using GCC/ICC since they
>>> share certain funky command line options (for dependency generation
>>> stuff)
>>>
>>>
>>>
>>> ---
>>> Diffs of the changes:  (+0 -11)
>>>
>>>  configure.ac |   11 -----------
>>>  1 files changed, 11 deletions(-)
>>>
>>>
>>> Index: llvm/autoconf/configure.ac
>>> diff -u llvm/autoconf/configure.ac:1.207
>>> llvm/autoconf/configure.ac:1.208
>>> --- llvm/autoconf/configure.ac:1.207	Sat Feb  4 23:56:51 2006
>>> +++ llvm/autoconf/configure.ac	Tue Feb 14 21:15:55 2006
>>> @@ -412,17 +412,6 @@
>>>      ;;
>>>  esac
>>>
>>> -if test "$GCC" != "yes" && test "$ICC" != "yes"
>>> -then
>>> -  AC_MSG_ERROR([gcc|icc required but not found])
>>> -fi
>>> -
>>> -dnl Ensure that compilation tools are GCC; we use GCC specific
>>> extensions
>>> -if test "$GXX" != "yes" && test "$IXX" != "yes"
>>> -then
>>> -  AC_MSG_ERROR([g++|icc required but not found])
>>> -fi
>>> -
>>>  dnl Verify that GCC is version 3.0 or higher
>>>  if test "$GCC" = "yes"
>>>  then
>>>
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
> -Chris
>
> --
> http://nondot.org/sabre/
> http://llvm.org/
>