[llvm-commits] CVS: llvm/lib/Transforms/Scalar/LoopUnswitch.cpp

[Chris Lattner]

Changes in directory llvm/lib/Transforms/Scalar:

LoopUnswitch.cpp updated: 1.13 -> 1.14
---
Log message:

Fix a case where UnswitchTrivialCondition broke critical edges with 
phi's in the successors


---
Diffs of the changes:  (+24 -1)

 LoopUnswitch.cpp |   25 ++++++++++++++++++++++++-
 1 files changed, 24 insertions(+), 1 deletion(-)


Index: llvm/lib/Transforms/Scalar/LoopUnswitch.cpp
diff -u llvm/lib/Transforms/Scalar/LoopUnswitch.cpp:1.13 llvm/lib/Transforms/Scalar/LoopUnswitch.cpp:1.14
--- llvm/lib/Transforms/Scalar/LoopUnswitch.cpp:1.13	Thu Feb  9 20:30:37 2006
+++ llvm/lib/Transforms/Scalar/LoopUnswitch.cpp	Fri Feb 10 13:08:15 2006
@@ -34,6 +34,7 @@
 #include "llvm/Analysis/LoopInfo.h"
 #include "llvm/Transforms/Utils/Cloning.h"
 #include "llvm/Transforms/Utils/Local.h"
+#include "llvm/Transforms/Utils/BasicBlockUtils.h"
 #include "llvm/ADT/Statistic.h"
 #include "llvm/Support/Debug.h"
 #include "llvm/Support/CommandLine.h"
@@ -255,6 +256,8 @@
   // loop.
   for (Loop::block_iterator I = L->block_begin(), E = L->block_end();
        I != E; ++I) {
+    for (BasicBlock::iterator BBI = (*I)->begin(), E = (*I)->end(); 
+         BBI != E; ++BBI)
     TerminatorInst *TI = (*I)->getTerminator();
     // FIXME: Handle invariant select instructions.
     
@@ -415,7 +418,27 @@
   
   // Split this block now, so that the loop maintains its exit block.
   assert(!L->contains(ExitBlock) && "Exit block is in the loop?");
-  BasicBlock *NewExit = SplitBlock(ExitBlock, true);
+  BasicBlock *NewExit;
+  if (BasicBlock *SinglePred = ExitBlock->getSinglePredecessor()) {
+    assert(SinglePred == L->getLoopLatch() && "Unexpected case");
+    NewExit = SplitBlock(ExitBlock, true);
+  } else {
+    // Otherwise, this is a critical edge.  Split block would split the wrong
+    // edge here, so we use SplitCriticalEdge, which allows us to specify the
+    // edge to split, not just the block.
+    TerminatorInst *LatchTerm = L->getLoopLatch()->getTerminator();
+    unsigned SuccNum = 0;
+    for (unsigned i = 0, e = LatchTerm->getNumSuccessors(); ; ++i) {
+      assert(i != e && "Didn't find edge?");
+      if (LatchTerm->getSuccessor(i) == ExitBlock) {
+        SuccNum = i;
+        break;
+      }
+    }
+    SplitCriticalEdge(LatchTerm, SuccNum, this);
+    NewExit = LatchTerm->getSuccessor(SuccNum);
+    assert(NewExit != ExitBlock && "Edge not split!");
+  }
   
   // Okay, now we have a position to branch from and a position to branch to, 
   // insert the new conditional branch.