[llvm-commits] CVS: llvm-poolalloc/lib/PoolAllocate/TransformFunctionBody.cpp
Sumant Kowshik
kowshik at cs.uiuc.edu
Tue Dec 6 10:07:03 PST 2005
Changes in directory llvm-poolalloc/lib/PoolAllocate:
TransformFunctionBody.cpp updated: 1.46 -> 1.47
---
Log message:
Removing unnecesary code mapping global nodes
---
Diffs of the changes: (+12 -8)
TransformFunctionBody.cpp | 20 ++++++++++++--------
1 files changed, 12 insertions(+), 8 deletions(-)
Index: llvm-poolalloc/lib/PoolAllocate/TransformFunctionBody.cpp
diff -u llvm-poolalloc/lib/PoolAllocate/TransformFunctionBody.cpp:1.46 llvm-poolalloc/lib/PoolAllocate/TransformFunctionBody.cpp:1.47
--- llvm-poolalloc/lib/PoolAllocate/TransformFunctionBody.cpp:1.46 Wed May 18 14:56:28 2005
+++ llvm-poolalloc/lib/PoolAllocate/TransformFunctionBody.cpp Tue Dec 6 12:06:43 2005
@@ -514,14 +514,18 @@
DSGraph::computeNodeMapping(CalleeGraph->getReturnNodeFor(*CF),
getDSNodeHFor(TheCall), NodeMapping, false);
- // Map the nodes that are pointed to by globals.
- DSScalarMap &CalleeSM = CalleeGraph->getScalarMap();
- for (DSScalarMap::global_iterator GI = G.getScalarMap().global_begin(),
- E = G.getScalarMap().global_end(); GI != E; ++GI)
- if (CalleeSM.count(*GI))
- DSGraph::computeNodeMapping(CalleeGraph->getNodeForValue(*GI),
- getDSNodeHFor(*GI),
- NodeMapping, false);
+ // This code seems redundant (and crashes occasionally)
+ // There is no reason to map globals here, since they are not passed as
+ // arguments
+
+ // Map the nodes that are pointed to by globals.
+ // DSScalarMap &CalleeSM = CalleeGraph->getScalarMap();
+ // for (DSScalarMap::global_iterator GI = G.getScalarMap().global_begin(),
+ // E = G.getScalarMap().global_end(); GI != E; ++GI)
+ // if (CalleeSM.count(*GI))
+ // DSGraph::computeNodeMapping(CalleeGraph->getNodeForValue(*GI),
+ // getDSNodeHFor(*GI),
+ // NodeMapping, false);
// Okay, now that we have established our mapping, we can figure out which
// pool descriptors to pass in...
More information about the llvm-commits
mailing list