[llvm-commits] CVS: llvm/lib/Transforms/Scalar/InstructionCombining.cpp

[Chris Lattner]

Changes in directory llvm/lib/Transforms/Scalar:

InstructionCombining.cpp updated: 1.393 -> 1.394
---
Log message:

Minor change to this file to support obscure cases with constant array amounts


---
Diffs of the changes:  (+16 -5)

 InstructionCombining.cpp |   21 ++++++++++++++++-----
 1 files changed, 16 insertions(+), 5 deletions(-)


Index: llvm/lib/Transforms/Scalar/InstructionCombining.cpp
diff -u llvm/lib/Transforms/Scalar/InstructionCombining.cpp:1.393 llvm/lib/Transforms/Scalar/InstructionCombining.cpp:1.394
--- llvm/lib/Transforms/Scalar/InstructionCombining.cpp:1.393	Wed Oct 26 12:18:16 2005
+++ llvm/lib/Transforms/Scalar/InstructionCombining.cpp	Thu Oct 27 00:53:56 2005
@@ -1709,7 +1709,6 @@
   return InsertNewInstBefore(New, I);
 }
 
-
 Instruction *InstCombiner::visitAnd(BinaryOperator &I) {
   bool Changed = SimplifyCommutative(I);
   Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
@@ -3776,7 +3775,7 @@
 Instruction *InstCombiner::PromoteCastOfAllocation(CastInst &CI,
                                                    AllocationInst &AI) {
   const PointerType *PTy = dyn_cast<PointerType>(CI.getType());
-  if (AI.isArrayAllocation() || !PTy) return 0;
+  if (!PTy) return 0;   // Not casting the allocation to a pointer type.
   
   // Remove any uses of AI that are dead.
   assert(!CI.use_empty() && "Dead instructions should be removed earlier!");
@@ -3813,12 +3812,23 @@
 
   uint64_t AllocElTySize = TD->getTypeSize(AllocElTy);
   uint64_t CastElTySize = TD->getTypeSize(CastElTy);
+  if (CastElTySize == 0 || AllocElTySize == 0) return 0;
 
   // If the allocation is for an even multiple of the cast type size
-  if (CastElTySize == 0 || AllocElTySize % CastElTySize != 0)
+  Value *Amt = 0;
+  if (AllocElTySize % CastElTySize == 0) {
+    Amt = ConstantUInt::get(Type::UIntTy, AllocElTySize/CastElTySize);
+    if (ConstantUInt *CI = dyn_cast<ConstantUInt>(AI.getOperand(0)))
+      Amt = ConstantExpr::getMul(CI, cast<ConstantUInt>(Amt));
+    else {
+      // Perform an explicit scale.
+      Instruction *Tmp = BinaryOperator::createMul(Amt, AI.getOperand(0),"tmp");
+      Amt = InsertNewInstBefore(Tmp, AI);
+    }
+  } else {
     return 0;
-  Value *Amt = ConstantUInt::get(Type::UIntTy,
-                                 AllocElTySize/CastElTySize);
+  }
+  
   std::string Name = AI.getName(); AI.setName("");
   AllocationInst *New;
   if (isa<MallocInst>(AI))
@@ -4061,6 +4071,7 @@
         break;
       }
     }
+      
   return 0;
 }