[llvm-commits] CVS: llvm/tools/bugpoint/Miscompilation.cpp

[Jeff Cohen]

Changes in directory llvm/tools/bugpoint:

Miscompilation.cpp updated: 1.71 -> 1.72
---
Log message:

When a function takes a variable number of pointer arguments, with a zero
pointer marking the end of the list, the zero *must* be cast to the pointer
type.  An un-cast zero is a 32-bit int, and at least on x86_64, gcc will
not extend the zero to 64 bits, thus allowing the upper 32 bits to be
random junk.

The new END_WITH_NULL macro may be used to annotate a such a function
so that GCC (version 4 or newer) will detect the use of un-casted zero
at compile time.


---
Diffs of the changes:  (+1 -1)

 Miscompilation.cpp |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)


Index: llvm/tools/bugpoint/Miscompilation.cpp
diff -u llvm/tools/bugpoint/Miscompilation.cpp:1.71 llvm/tools/bugpoint/Miscompilation.cpp:1.72
--- llvm/tools/bugpoint/Miscompilation.cpp:1.71	Tue Aug  2 18:25:56 2005
+++ llvm/tools/bugpoint/Miscompilation.cpp	Sat Oct 22 23:37:20 2005
@@ -666,7 +666,7 @@
   Function *resolverFunc =
     Safe->getOrInsertFunction("getPointerToNamedFunction",
                               PointerType::get(Type::SByteTy),
-                              PointerType::get(Type::SByteTy), 0);
+                              PointerType::get(Type::SByteTy), (Type *)0);
 
   // Use the function we just added to get addresses of functions we need.
   for (Module::iterator F = Safe->begin(), E = Safe->end(); F != E; ++F) {