[llvm-commits] CVS: llvm/Makefile.rules

Jeff Cohen jeffc at jolt-lang.org
Sat Oct 22 21:37:39 PDT 2005

Changes in directory llvm:

Makefile.rules updated: 1.328 -> 1.329
Log message:

When a function takes a variable number of pointer arguments, with a zero
pointer marking the end of the list, the zero *must* be cast to the pointer
type.  An un-cast zero is a 32-bit int, and at least on x86_64, gcc will
not extend the zero to 64 bits, thus allowing the upper 32 bits to be
random junk.

The new END_WITH_NULL macro may be used to annotate a such a function
so that GCC (version 4 or newer) will detect the use of un-casted zero
at compile time.

Diffs of the changes:  (+1 -1)

 Makefile.rules |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: llvm/Makefile.rules
diff -u llvm/Makefile.rules:1.328 llvm/Makefile.rules:1.329
--- llvm/Makefile.rules:1.328	Fri Oct 21 14:02:44 2005
+++ llvm/Makefile.rules	Sat Oct 22 23:37:19 2005
@@ -221,7 +221,7 @@
-CXX.Flags += $(CXXFLAGS)
+CXX.Flags += $(CXXFLAGS) -Wformat
 C.Flags   += $(CFLAGS)
 CPP.Flags += $(CPPFLAGS)
 LD.Flags  += $(LDFLAGS)

More information about the llvm-commits mailing list