[llvm-commits] CVS: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

[Chris Lattner]

Changes in directory llvm/lib/CodeGen/SelectionDAG:

SelectionDAGISel.cpp updated: 1.71 -> 1.72
---
Log message:

Enable critical edge splitting by default


---
Diffs of the changes:  (+10 -16)

 SelectionDAGISel.cpp |   26 ++++++++++----------------
 1 files changed, 10 insertions(+), 16 deletions(-)


Index: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
diff -u llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:1.71 llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:1.72
--- llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:1.71	Wed Aug 17 01:37:43 2005
+++ llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp	Thu Aug 18 12:35:14 2005
@@ -36,11 +36,6 @@
 #include <iostream>
 using namespace llvm;
 
-static cl::opt<bool>
-SplitPHICritEdges("split-phi-constant-crit-edges", cl::Hidden,
-         cl::desc("Split critical edges for PHI values that are constants"));
-
-
 #ifndef _NDEBUG
 static cl::opt<bool>
 ViewDAGs("view-isel-dags", cl::Hidden,
@@ -966,8 +961,8 @@
 }
 
 void SelectionDAGISel::getAnalysisUsage(AnalysisUsage &AU) const {
-  if (!SplitPHICritEdges)
-    AU.setPreservesAll();
+  // FIXME: we only modify the CFG to split critical edges.  This
+  // updates dom and loop info.
 }
 
 
@@ -979,15 +974,14 @@
   // First pass, split all critical edges for PHI nodes with incoming values
   // that are constants, this way the load of the constant into a vreg will not
   // be placed into MBBs that are used some other way.
-  if (SplitPHICritEdges)
-    for (Function::iterator BB = Fn.begin(), E = Fn.end(); BB != E; ++BB) {
-      PHINode *PN;
-      for (BasicBlock::iterator BBI = BB->begin();
-           (PN = dyn_cast<PHINode>(BBI)); ++BBI)
-        for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i)
-          if (isa<Constant>(PN->getIncomingValue(i)))
-            SplitCriticalEdge(PN->getIncomingBlock(i), BB);
-    }
+  for (Function::iterator BB = Fn.begin(), E = Fn.end(); BB != E; ++BB) {
+    PHINode *PN;
+    for (BasicBlock::iterator BBI = BB->begin();
+         (PN = dyn_cast<PHINode>(BBI)); ++BBI)
+      for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i)
+        if (isa<Constant>(PN->getIncomingValue(i)))
+          SplitCriticalEdge(PN->getIncomingBlock(i), BB);
+  }
 
   FunctionLoweringInfo FuncInfo(TLI, Fn, MF);