[llvm-commits] CVS: llvm/lib/CodeGen/SelectionDAG/SelectionDAGPrinter.cpp

[Reid Spencer]

On Wed, 2005-07-13 at 23:09 -0500, Chris Lattner wrote:
> On Wed, 13 Jul 2005, Reid Spencer wrote:
> >>    std::cerr << "Running 'dot' program... " << std::flush;
> >>    if (system(("dot -Tps -Nfontname=Courier -Gsize=7.5,10 " + Filename
> >>                + " > /tmp/dag.tempgraph.ps").c_str())) {
> >> -    std::cerr << "Error running dot: 'dot' not in path?\n";
> >> +    std::cerr << "Error viewing graph: 'dot' not in path?\n";
> >>    } else {
> >>      std::cerr << "\n";
> >>      system("gv /tmp/dag.tempgraph.ps");
> >
> > None of this code is portable because of the use of the system call. I
> > know its convenient but windows doesn't have it. We have a facility in
> > lib/Support for executing external programs. You should use it.
> 
> I'm not convinced.  Windows won't have 'gv' or 'Graphviz' either.  I'd be 
> happy to make the second one depend on gv being found by autoconf though.

That's crap, Chris. Here's the Graphviz Win32 download page:

http://home.so-net.net.tw/oodtsen/wingraphviz/index.htm

Graphviz is definitely available on Windows.  Windows users already
suffer enough with LLVM, why add further deprecated features? 

As for gv, we should have a test and a path variable for it too ..
actually for *all* programs we rely on. I'll add gv. Let me know if
there are others.

Reid.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20050713/6899a7d5/attachment.sig>