[llvm-commits] CVS: llvm/lib/Target/Alpha/Alpha.td AlphaISelPattern.cpp AlphaInstrInfo.td AlphaRegisterInfo.cpp

Andrew Lenharth alenhar2 at cs.uiuc.edu
Thu Jun 23 16:42:16 PDT 2005



Changes in directory llvm/lib/Target/Alpha:

Alpha.td updated: 1.3 -> 1.4
AlphaISelPattern.cpp updated: 1.126 -> 1.127
AlphaInstrInfo.td updated: 1.44 -> 1.45
AlphaRegisterInfo.cpp updated: 1.21 -> 1.22
---
Log message:

remove a pseudo instruction, make ret always right, and fix vararg chains

---
Diffs of the changes:  (+20 -15)

 Alpha.td              |    2 +-
 AlphaISelPattern.cpp  |   28 ++++++++++++++++++----------
 AlphaInstrInfo.td     |    3 ---
 AlphaRegisterInfo.cpp |    2 +-
 4 files changed, 20 insertions(+), 15 deletions(-)


Index: llvm/lib/Target/Alpha/Alpha.td
diff -u llvm/lib/Target/Alpha/Alpha.td:1.3 llvm/lib/Target/Alpha/Alpha.td:1.4
--- llvm/lib/Target/Alpha/Alpha.td:1.3	Tue Apr  5 15:51:46 2005
+++ llvm/lib/Target/Alpha/Alpha.td	Thu Jun 23 18:42:05 2005
@@ -46,7 +46,7 @@
 	//Frame pointer
 //	R15, 
 	//return address
-	R26, 
+//	R26, 
 	//Stack Pointer
 //	R30,
          F2, F3, F4, F5, F6, F7, F8, F9];


Index: llvm/lib/Target/Alpha/AlphaISelPattern.cpp
diff -u llvm/lib/Target/Alpha/AlphaISelPattern.cpp:1.126 llvm/lib/Target/Alpha/AlphaISelPattern.cpp:1.127
--- llvm/lib/Target/Alpha/AlphaISelPattern.cpp:1.126	Thu Jun 23 11:48:51 2005
+++ llvm/lib/Target/Alpha/AlphaISelPattern.cpp	Thu Jun 23 18:42:05 2005
@@ -76,6 +76,7 @@
     int VarArgsOffset;  // What is the offset to the first vaarg
     int VarArgsBase;    // What is the base FrameIndex
     unsigned GP; //GOT vreg
+    unsigned RA; //Return Address
   public:
     AlphaTargetLowering(TargetMachine &TM) : TargetLowering(TM) {
       // Set up the TargetLowering object.
@@ -171,6 +172,11 @@
     {
       BuildMI(BB, Alpha::BIS, 2, Alpha::R29).addReg(GP).addReg(GP);
     }
+    void restoreRA(MachineBasicBlock* BB)
+    {
+      BuildMI(BB, Alpha::BIS, 2, Alpha::R26).addReg(RA).addReg(RA);
+    }
+
   };
 }
 
@@ -262,6 +268,7 @@
   int count = 0;
 
   GP = AddLiveIn(MF, Alpha::R29, getRegClassFor(MVT::i64));
+  RA = AddLiveIn(MF, Alpha::R26, getRegClassFor(MVT::i64));
 
   for (Function::arg_iterator I = F.arg_begin(), E = F.arg_end(); I != E; ++I)
   {
@@ -418,7 +425,7 @@
   SDOperand Base = DAG.getLoad(MVT::i64, Chain, VAList, DAG.getSrcValue(NULL));
   SDOperand Tmp = DAG.getNode(ISD::ADD, MVT::i64, VAList, 
                               DAG.getConstant(8, MVT::i64));
-  SDOperand Offset = DAG.getNode(ISD::SEXTLOAD, MVT::i64, Chain, Tmp, 
+  SDOperand Offset = DAG.getNode(ISD::SEXTLOAD, MVT::i64, Base.getValue(1), Tmp, 
                                  DAG.getSrcValue(NULL), MVT::i32);
   SDOperand DataPtr = DAG.getNode(ISD::ADD, MVT::i64, Base, Offset);
   if (ArgTy->isFloatingPoint())
@@ -433,18 +440,18 @@
 
   SDOperand Result;
   if (ArgTy == Type::IntTy)
-    Result = DAG.getNode(ISD::SEXTLOAD, MVT::i64, Chain, DataPtr, 
+    Result = DAG.getNode(ISD::SEXTLOAD, MVT::i64, Offset.getValue(1), DataPtr, 
                          DAG.getSrcValue(NULL), MVT::i32);
   else if (ArgTy == Type::UIntTy)
-    Result = DAG.getNode(ISD::ZEXTLOAD, MVT::i64, Chain, DataPtr, 
+    Result = DAG.getNode(ISD::ZEXTLOAD, MVT::i64, Offset.getValue(1), DataPtr, 
                          DAG.getSrcValue(NULL), MVT::i32);
   else
-    Result = DAG.getLoad(getValueType(ArgTy), Chain, DataPtr, 
+    Result = DAG.getLoad(getValueType(ArgTy), Offset.getValue(1), DataPtr, 
                          DAG.getSrcValue(NULL));
 
   SDOperand NewOffset = DAG.getNode(ISD::ADD, MVT::i64, Offset, 
                                     DAG.getConstant(8, MVT::i64));
-  SDOperand Update = DAG.getNode(ISD::TRUNCSTORE, MVT::Other, Result, NewOffset, 
+  SDOperand Update = DAG.getNode(ISD::TRUNCSTORE, MVT::Other, Result.getValue(1), NewOffset, 
                                  Tmp, DAG.getSrcValue(NULL), MVT::i32);
   Result = DAG.getNode(ISD::TRUNCATE, getValueType(ArgTy), Result);
 
@@ -460,10 +467,12 @@
                                  Val, Dest, DAG.getSrcValue(NULL));
   SDOperand NP = DAG.getNode(ISD::ADD, MVT::i64, Src, 
                              DAG.getConstant(8, MVT::i64));
-  Val = DAG.getNode(ISD::SEXTLOAD, MVT::i64, Chain, NP, DAG.getSrcValue(NULL), 
+  Val = DAG.getNode(ISD::SEXTLOAD, MVT::i64, Result, NP, DAG.getSrcValue(NULL), 
                     MVT::i32);
+  SDOperand NPD = DAG.getNode(ISD::ADD, MVT::i64, Dest, 
+                             DAG.getConstant(8, MVT::i64));
   Result = DAG.getNode(ISD::TRUNCSTORE, MVT::Other, Val.getValue(1),
-                       Val, Dest, DAG.getSrcValue(NULL), MVT::i32);
+                       Val, NPD, DAG.getSrcValue(NULL), MVT::i32);
   return std::make_pair(Result, Result);
 }
 
@@ -2388,9 +2397,8 @@
       Select(N.getOperand(0));
       break;
     }
-    //Tmp2 = AlphaLowering.getRetAddr();
-    //BuildMI(BB, Alpha::BIS, 2, Alpha::R26).addReg(Tmp2).addReg(Tmp2);
-    BuildMI(BB, Alpha::RETURN, 0); // Just emit a 'ret' instruction
+    AlphaLowering.restoreRA(BB);
+    BuildMI(BB, Alpha::RET, 1, Alpha::R31).addReg(Alpha::R26); // Just emit a 'ret' instruction
     return;
 
   case ISD::TRUNCSTORE:


Index: llvm/lib/Target/Alpha/AlphaInstrInfo.td
diff -u llvm/lib/Target/Alpha/AlphaInstrInfo.td:1.44 llvm/lib/Target/Alpha/AlphaInstrInfo.td:1.45
--- llvm/lib/Target/Alpha/AlphaInstrInfo.td:1.44	Wed Jun 22 12:19:45 2005
+++ llvm/lib/Target/Alpha/AlphaInstrInfo.td	Thu Jun 23 18:42:05 2005
@@ -53,9 +53,6 @@
     Uses = [R29] in
       def CALL : PseudoInstAlpha< (ops s64imm:$TARGET), "jsr $TARGET">; //Jump to subroutine
 
-let isReturn = 1, isTerminator = 1 in
-  def RETURN : PseudoInstAlpha<(ops ), "ret $$31,($$26),1">; //Return from subroutine
-
 //These are evil as they get expanded into multiple instructions to take care of reallocation
 let Uses = [R29], Defs = [R28] in {
   def LOAD_ADDR : PseudoInstAlpha<(ops GPRC:$RA, s64imm:$DISP), "lda $RA,$DISP">;  //Load address


Index: llvm/lib/Target/Alpha/AlphaRegisterInfo.cpp
diff -u llvm/lib/Target/Alpha/AlphaRegisterInfo.cpp:1.21 llvm/lib/Target/Alpha/AlphaRegisterInfo.cpp:1.22
--- llvm/lib/Target/Alpha/AlphaRegisterInfo.cpp:1.21	Fri Apr 22 12:50:14 2005
+++ llvm/lib/Target/Alpha/AlphaRegisterInfo.cpp	Thu Jun 23 18:42:05 2005
@@ -272,7 +272,7 @@
   const MachineFrameInfo *MFI = MF.getFrameInfo();
   MachineBasicBlock::iterator MBBI = prior(MBB.end());
   MachineInstr *MI;
-  assert((MBBI->getOpcode() == Alpha::RET || MBBI->getOpcode() == Alpha::RETURN)
+  assert((MBBI->getOpcode() == Alpha::RET)
          && "Can only insert epilog into returning blocks");
 
   bool FP = hasFP(MF);






More information about the llvm-commits mailing list