[llvm-commits] CVS: llvm/lib/Target/IA64/IA64ISelPattern.cpp

Duraid Madina duraid at octopus.com.au
Fri May 20 04:39:28 PDT 2005



Changes in directory llvm/lib/Target/IA64:

IA64ISelPattern.cpp updated: 1.43 -> 1.44
---
Log message:

re-enable direct calls, this should just be a performance boost 



---
Diffs of the changes:  (+5 -6)

 IA64ISelPattern.cpp |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)


Index: llvm/lib/Target/IA64/IA64ISelPattern.cpp
diff -u llvm/lib/Target/IA64/IA64ISelPattern.cpp:1.43 llvm/lib/Target/IA64/IA64ISelPattern.cpp:1.44
--- llvm/lib/Target/IA64/IA64ISelPattern.cpp:1.43	Sun May 15 09:44:13 2005
+++ llvm/lib/Target/IA64/IA64ISelPattern.cpp	Fri May 20 06:39:17 2005
@@ -2151,16 +2151,13 @@
         }
       }
 
-      /*  XXX we want to re-enable direct branches! crippling them now
-       *  to stress-test indirect branches.:
-    //build the right kind of call
+    // build the right kind of call. if we can branch directly, do so:
     if (GlobalAddressSDNode *GASD =
                dyn_cast<GlobalAddressSDNode>(N.getOperand(1)))
       {
         BuildMI(BB, IA64::BRCALL, 1).addGlobalAddress(GASD->getGlobal(),true);
         IA64Lowering.restoreGP_SP_RP(BB);
-      }
-             ^^^^^^^^^^^^^ we want this code one day XXX */
+      } else
     if (ExternalSymbolSDNode *ESSDN =
              dyn_cast<ExternalSymbolSDNode>(N.getOperand(1)))
       { // FIXME : currently need this case for correctness, to avoid
@@ -2169,7 +2166,9 @@
           .addExternalSymbol(ESSDN->getSymbol(), true);
         IA64Lowering.restoreGP_SP_RP(BB);
       }
-    else {
+    else { // otherwise we need to get the function descriptor
+           // load the branch target (function)'s entry point and
+	   // GP, then branch
       Tmp1 = SelectExpr(N.getOperand(1));
 
       unsigned targetEntryPoint=MakeReg(MVT::i64);






More information about the llvm-commits mailing list