[llvm-commits] CVS: llvm/lib/Target/PowerPC/PPC32ISelPattern.cpp
Nate Begeman
natebegeman at mac.com
Sat Apr 9 22:53:25 PDT 2005
Changes in directory llvm/lib/Target/PowerPC:
PPC32ISelPattern.cpp updated: 1.60 -> 1.61
---
Log message:
Fix 64 bit argument loading that straddles the args in regs / args on stack
boundary.
---
Diffs of the changes: (+15 -7)
PPC32ISelPattern.cpp | 22 +++++++++++++++-------
1 files changed, 15 insertions(+), 7 deletions(-)
Index: llvm/lib/Target/PowerPC/PPC32ISelPattern.cpp
diff -u llvm/lib/Target/PowerPC/PPC32ISelPattern.cpp:1.60 llvm/lib/Target/PowerPC/PPC32ISelPattern.cpp:1.61
--- llvm/lib/Target/PowerPC/PPC32ISelPattern.cpp:1.60 Sat Apr 9 20:48:29 2005
+++ llvm/lib/Target/PowerPC/PPC32ISelPattern.cpp Sun Apr 10 00:53:14 2005
@@ -151,14 +151,22 @@
break;
case MVT::i64: ObjSize = 8;
if (!ArgLive) break;
- // FIXME: can split 64b load between reg/mem if it is last arg in regs
- if (GPR_remaining > 1) {
+ if (GPR_remaining > 0) {
+ SDOperand argHi, argLo;
MF.addLiveIn(GPR[GPR_idx]);
- MF.addLiveIn(GPR[GPR_idx+1]);
- // Copy the extracted halves into the virtual registers
- SDOperand argHi = DAG.getCopyFromReg(GPR[GPR_idx], MVT::i32,
- DAG.getRoot());
- SDOperand argLo = DAG.getCopyFromReg(GPR[GPR_idx+1], MVT::i32, argHi);
+ argHi = DAG.getCopyFromReg(GPR[GPR_idx], MVT::i32, DAG.getRoot());
+ // If we have two or more remaining argument registers, then both halves
+ // of the i64 can be sourced from there. Otherwise, the lower half will
+ // have to come off the stack. This can happen when an i64 is preceded
+ // by 28 bytes of arguments.
+ if (GPR_remaining > 1) {
+ MF.addLiveIn(GPR[GPR_idx+1]);
+ argLo = DAG.getCopyFromReg(GPR[GPR_idx+1], MVT::i32, argHi);
+ } else {
+ int FI = MFI->CreateFixedObject(4, ArgOffset+4);
+ SDOperand FIN = DAG.getFrameIndex(FI, MVT::i32);
+ argLo = DAG.getLoad(MVT::i32, DAG.getEntryNode(), FIN);
+ }
// Build the outgoing arg thingy
argt = DAG.getNode(ISD::BUILD_PAIR, MVT::i64, argLo, argHi);
newroot = argLo;
More information about the llvm-commits
mailing list