[llvm-commits] CVS: llvm/lib/Target/PowerPC/PPC32ISelSimple.cpp

[Chris Lattner]

Changes in directory llvm/lib/Target/PowerPC:

PPC32ISelSimple.cpp updated: 1.137 -> 1.138
---
Log message:

rename getPPCOpcodeForSetCCNumber -> getPPCOpcodeForSetCCOpode to be more
correct.  Remove the EmitComparison retvalue, as it is always the first arg.

Fix a place where we incorrectly passed in the setcc opcode instead of the
setcc number, causing us to miscompile crafty.  Crafty now works!


---
Diffs of the changes:  (+21 -21)

 PPC32ISelSimple.cpp |   42 +++++++++++++++++++++---------------------
 1 files changed, 21 insertions(+), 21 deletions(-)


Index: llvm/lib/Target/PowerPC/PPC32ISelSimple.cpp
diff -u llvm/lib/Target/PowerPC/PPC32ISelSimple.cpp:1.137 llvm/lib/Target/PowerPC/PPC32ISelSimple.cpp:1.138
--- llvm/lib/Target/PowerPC/PPC32ISelSimple.cpp:1.137	Sat Apr  9 17:05:17 2005
+++ llvm/lib/Target/PowerPC/PPC32ISelSimple.cpp	Sat Apr  9 20:03:31 2005
@@ -292,9 +292,9 @@
 
     // Comparison operators...
     void visitSetCondInst(SetCondInst &I);
-    unsigned EmitComparison(unsigned OpNum, Value *Op0, Value *Op1,
-                            MachineBasicBlock *MBB,
-                            MachineBasicBlock::iterator MBBI);
+    void EmitComparison(unsigned OpNum, Value *Op0, Value *Op1,
+                        MachineBasicBlock *MBB,
+                        MachineBasicBlock::iterator MBBI);
     void visitSelectInst(SelectInst &SI);
     
     
@@ -1049,7 +1049,7 @@
   }
 }
 
-static unsigned getPPCOpcodeForSetCCNumber(unsigned Opcode) {
+static unsigned getPPCOpcodeForSetCCOpcode(unsigned Opcode) {
   switch (Opcode) {
   default: assert(0 && "Unknown setcc instruction!");
   case Instruction::SetEQ: return PPC::BEQ;
@@ -1101,12 +1101,12 @@
   return Reg;
 }
 
-/// EmitComparison - emits a comparison of the two operands, returning the
-/// extended setcc code to use.  The result is in CR0.
+/// EmitComparison - emits a comparison of the two operands. The result is in
+/// CR0.
 ///
-unsigned PPC32ISel::EmitComparison(unsigned OpNum, Value *Op0, Value *Op1,
-                                   MachineBasicBlock *MBB,
-                                   MachineBasicBlock::iterator IP) {
+void PPC32ISel::EmitComparison(unsigned OpNum, Value *Op0, Value *Op1,
+                               MachineBasicBlock *MBB,
+                               MachineBasicBlock::iterator IP) {
   // The arguments are already supposed to be of the same type.
   const Type *CompTy = Op0->getType();
   unsigned Class = getClassB(CompTy);
@@ -1134,7 +1134,7 @@
         unsigned Op1r = getReg(Op1, MBB, IP);
         BuildMI(*MBB, IP, Opcode, 2, PPC::CR0).addReg(Op0r).addReg(Op1r);
       }
-      return OpNum;
+      return;
     } else {
       assert(Class == cLong && "Unknown integer class!");
       unsigned LowCst = CI->getRawValue();
@@ -1155,7 +1155,7 @@
         BuildMI(*MBB, IP, PPC::XORIS, 2, HiTmp).addReg(HiLow)
           .addImm(HiCst >> 16);
         BuildMI(*MBB, IP, PPC::ORo, 2, FinalTmp).addReg(LoTmp).addReg(HiTmp);
-        return OpNum;
+        return;
       } else {
         unsigned ConstReg = makeAnotherReg(CompTy);
         copyConstantToRegister(MBB, IP, CI, ConstReg);
@@ -1168,7 +1168,7 @@
         BuildMI(*MBB, IP, PPC::CRAND, 3).addImm(2).addImm(2).addImm(CR1field);
         BuildMI(*MBB, IP, PPC::CROR, 3).addImm(CR0field).addImm(CR0field)
           .addImm(2);
-        return OpNum;
+        return;
       }
     }
   }
@@ -1207,10 +1207,10 @@
       BuildMI(*MBB, IP, PPC::CRAND, 3).addImm(2).addImm(2).addImm(CR1field);
       BuildMI(*MBB, IP, PPC::CROR, 3).addImm(CR0field).addImm(CR0field)
         .addImm(2);
-      return OpNum;
+      return;
     }
   }
-  return OpNum;
+  return;
 }
 
 /// visitSetCondInst - emit code to calculate the condition via
@@ -1306,7 +1306,7 @@
       return;
   	}
   }
-  unsigned PPCOpcode = getPPCOpcodeForSetCCNumber(Opcode);
+  unsigned PPCOpcode = getPPCOpcodeForSetCCOpcode(Opcode);
 
   // Create an iterator with which to insert the MBB for copying the false value
   // and the MBB to hold the PHI instruction for this SetCC.
@@ -1320,7 +1320,7 @@
   //   cmpTY cr0, r1, r2
   //   %TrueValue = li 1
   //   bCC sinkMBB
-  EmitComparison(Opcode, Op0, Op1, BB, BB->end());
+  EmitComparison(OpNum, Op0, Op1, BB, BB->end());
   unsigned TrueValue = makeAnotherReg(I.getType());
   BuildMI(BB, PPC::LI, 1, TrueValue).addSImm(1);
   MachineBasicBlock *copy0MBB = new MachineBasicBlock(LLVM_BB);
@@ -1446,12 +1446,12 @@
         return;
       }
     }
-    OpNum = EmitComparison(OpNum, SCI->getOperand(0),SCI->getOperand(1),MBB,IP);
-    Opcode = getPPCOpcodeForSetCCNumber(SCI->getOpcode());
+    EmitComparison(OpNum, SCI->getOperand(0),SCI->getOperand(1),MBB,IP);
+    Opcode = getPPCOpcodeForSetCCOpcode(SCI->getOpcode());
   } else {
     unsigned CondReg = getReg(Cond, MBB, IP);
     BuildMI(*MBB, IP, PPC::CMPWI, 2, PPC::CR0).addReg(CondReg).addSImm(0);
-    Opcode = getPPCOpcodeForSetCCNumber(Instruction::SetNE);
+    Opcode = getPPCOpcodeForSetCCOpcode(Instruction::SetNE);
   }
 
   MachineBasicBlock *thisMBB = BB;
@@ -1633,9 +1633,9 @@
   }
 
   unsigned OpNum = getSetCCNumber(SCI->getOpcode());
-  unsigned Opcode = getPPCOpcodeForSetCCNumber(SCI->getOpcode());
+  unsigned Opcode = getPPCOpcodeForSetCCOpcode(SCI->getOpcode());
   MachineBasicBlock::iterator MII = BB->end();
-  OpNum = EmitComparison(OpNum, SCI->getOperand(0), SCI->getOperand(1), BB,MII);
+  EmitComparison(OpNum, SCI->getOperand(0), SCI->getOperand(1), BB,MII);
   
   if (BI.getSuccessor(0) != NextBB) {
     BuildMI(BB, PPC::COND_BRANCH, 4).addReg(PPC::CR0).addImm(Opcode)