[llvm-commits] CVS: llvm/lib/Analysis/DataStructure/TopDownClosure.cpp

Chris Lattner lattner at cs.uiuc.edu
Mon Mar 21 00:43:50 PST 2005



Changes in directory llvm/lib/Analysis/DataStructure:

TopDownClosure.cpp updated: 1.80 -> 1.81
---
Log message:

'note to self'


---
Diffs of the changes:  (+5 -2)

 TopDownClosure.cpp |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)


Index: llvm/lib/Analysis/DataStructure/TopDownClosure.cpp
diff -u llvm/lib/Analysis/DataStructure/TopDownClosure.cpp:1.80 llvm/lib/Analysis/DataStructure/TopDownClosure.cpp:1.81
--- llvm/lib/Analysis/DataStructure/TopDownClosure.cpp:1.80	Sun Mar 20 22:55:35 2005
+++ llvm/lib/Analysis/DataStructure/TopDownClosure.cpp	Mon Mar 21 02:43:32 2005
@@ -188,8 +188,11 @@
   std::sort(EdgesFromCaller.begin(), EdgesFromCaller.end());
 
 
-  // Merge information from the globals graph into this graph.
-  // FIXME: is this necessary?
+  // Merge information from the globals graph into this graph.  FIXME: This is
+  // stupid.  Instead of us cloning information from the GG into this graph,
+  // then having RemoveDeadNodes clone it back, we should do all of this as a
+  // post-pass over all of the graphs.  We need to take cloning out of
+  // removeDeadNodes and gut removeDeadNodes at the same time first though. :(
   {
     DSGraph &GG = *DSG.getGlobalsGraph();
     ReachabilityCloner RC(DSG, GG,






More information about the llvm-commits mailing list