[llvm-commits] CVS: llvm/lib/Analysis/DataStructure/TopDownClosure.cpp Steensgaard.cpp

Chris Lattner lattner at cs.uiuc.edu
Sat Mar 19 18:40:33 PST 2005



Changes in directory llvm/lib/Analysis/DataStructure:

TopDownClosure.cpp updated: 1.76 -> 1.77
Steensgaard.cpp updated: 1.47 -> 1.48
---
Log message:

Make use of simpler DSNode methods.


---
Diffs of the changes:  (+8 -14)

 Steensgaard.cpp    |   14 +++++---------
 TopDownClosure.cpp |    8 +++-----
 2 files changed, 8 insertions(+), 14 deletions(-)


Index: llvm/lib/Analysis/DataStructure/TopDownClosure.cpp
diff -u llvm/lib/Analysis/DataStructure/TopDownClosure.cpp:1.76 llvm/lib/Analysis/DataStructure/TopDownClosure.cpp:1.77
--- llvm/lib/Analysis/DataStructure/TopDownClosure.cpp:1.76	Sat Mar 19 16:23:45 2005
+++ llvm/lib/Analysis/DataStructure/TopDownClosure.cpp	Sat Mar 19 20:39:49 2005
@@ -37,11 +37,9 @@
   for (unsigned i = 0, e = N->getNumLinks(); i != e; ++i) {
     DSNodeHandle &NH = N->getLink(i*N->getPointerSize());
     if (DSNode *NN = NH.getNode()) {
-      const std::vector<GlobalValue*> &Globals = NN->getGlobals();
-      for (unsigned G = 0, e = Globals.size(); G != e; ++G)
-        if (Function *F = dyn_cast<Function>(Globals[G]))
-          ArgsRemainIncomplete.insert(F);
-
+      std::vector<Function*> Functions;
+      NN->addFullFunctionList(Functions);
+      ArgsRemainIncomplete.insert(Functions.begin(), Functions.end());
       markReachableFunctionsExternallyAccessible(NN, Visited);
     }
   }


Index: llvm/lib/Analysis/DataStructure/Steensgaard.cpp
diff -u llvm/lib/Analysis/DataStructure/Steensgaard.cpp:1.47 llvm/lib/Analysis/DataStructure/Steensgaard.cpp:1.48
--- llvm/lib/Analysis/DataStructure/Steensgaard.cpp:1.47	Sat Mar 19 16:23:45 2005
+++ llvm/lib/Analysis/DataStructure/Steensgaard.cpp	Sat Mar 19 20:39:49 2005
@@ -165,21 +165,17 @@
     DSCallSite &CurCall = *CI++;
     
     // Loop over the called functions, eliminating as many as possible...
-    std::vector<GlobalValue*> CallTargets;
+    std::vector<Function*> CallTargets;
     if (CurCall.isDirectCall())
       CallTargets.push_back(CurCall.getCalleeFunc());
     else 
-      CallTargets = CurCall.getCalleeNode()->getGlobals();
+      CurCall.getCalleeNode()->addFullFunctionList(CallTargets);
 
     for (unsigned c = 0; c != CallTargets.size(); ) {
       // If we can eliminate this function call, do so!
-      bool Eliminated = false;
-      if (Function *F = dyn_cast<Function>(CallTargets[c]))
-        if (!F->isExternal()) {
-          ResolveFunctionCall(F, CurCall, RetValMap[F]);
-          Eliminated = true;
-        }
-      if (Eliminated) {
+      Function *F = CallTargets[c];
+      if (!F->isExternal()) {
+        ResolveFunctionCall(F, CurCall, RetValMap[F]);
         CallTargets[c] = CallTargets.back();
         CallTargets.pop_back();
       } else






More information about the llvm-commits mailing list