[llvm-commits] CVS: llvm/include/llvm/Argument.h BasicBlock.h Constant.h Function.h GlobalVariable.h Instruction.h Value.h

[Chris Lattner]

Changes in directory llvm/include/llvm:

Argument.h updated: 1.9 -> 1.10
BasicBlock.h updated: 1.49 -> 1.50
Constant.h updated: 1.21 -> 1.22
Function.h updated: 1.60 -> 1.61
GlobalVariable.h updated: 1.31 -> 1.32
Instruction.h updated: 1.64 -> 1.65
Value.h updated: 1.72 -> 1.73
---
Log message:

remove all of the various setName implementations, consolidating them into 
Value::setName, which is no longer virtual.


---
Diffs of the changes:  (+1 -21)

 Argument.h       |    3 ---
 BasicBlock.h     |    3 ---
 Constant.h       |    3 ---
 Function.h       |    3 ---
 GlobalVariable.h |    3 ---
 Instruction.h    |    3 ---
 Value.h          |    4 +---
 7 files changed, 1 insertion(+), 21 deletions(-)


Index: llvm/include/llvm/Argument.h
diff -u llvm/include/llvm/Argument.h:1.9 llvm/include/llvm/Argument.h:1.10
--- llvm/include/llvm/Argument.h:1.9	Sat Mar  5 12:59:35 2005
+++ llvm/include/llvm/Argument.h	Sat Mar  5 13:51:20 2005
@@ -39,9 +39,6 @@
   ///
   Argument(const Type *Ty, const std::string &Name = "", Function *F = 0);
 
-  /// setName - Specialize setName to handle symbol table majik.
-  virtual void setName(const std::string &name);
-
   inline const Function *getParent() const { return Parent; }
   inline       Function *getParent()       { return Parent; }
  


Index: llvm/include/llvm/BasicBlock.h
diff -u llvm/include/llvm/BasicBlock.h:1.49 llvm/include/llvm/BasicBlock.h:1.50
--- llvm/include/llvm/BasicBlock.h:1.49	Sat Mar  5 12:59:35 2005
+++ llvm/include/llvm/BasicBlock.h	Sat Mar  5 13:51:20 2005
@@ -76,9 +76,6 @@
              BasicBlock *InsertBefore = 0);
   ~BasicBlock();
 
-  // Specialize setName to take care of symbol table majik
-  virtual void setName(const std::string &name);
-
   /// getParent - Return the enclosing method, or null if none
   ///
   const Function *getParent() const { return InstList.getParent(); }


Index: llvm/include/llvm/Constant.h
diff -u llvm/include/llvm/Constant.h:1.21 llvm/include/llvm/Constant.h:1.22
--- llvm/include/llvm/Constant.h:1.21	Sat Mar  5 12:59:36 2005
+++ llvm/include/llvm/Constant.h	Sat Mar  5 13:51:20 2005
@@ -26,9 +26,6 @@
 
   void destroyConstantImpl();
 public:
-  // setName - Specialize setName to handle symbol table majik.
-  virtual void setName(const std::string &name);
-
   /// Static constructor to get a '0' constant of arbitrary type...
   ///
   static Constant *getNullValue(const Type *Ty);


Index: llvm/include/llvm/Function.h
diff -u llvm/include/llvm/Function.h:1.60 llvm/include/llvm/Function.h:1.61
--- llvm/include/llvm/Function.h:1.60	Sat Mar  5 12:59:36 2005
+++ llvm/include/llvm/Function.h	Sat Mar  5 13:51:20 2005
@@ -85,9 +85,6 @@
            const std::string &N = "", Module *M = 0);
   ~Function();
 
-  // Specialize setName to handle symbol table majik.
-  virtual void setName(const std::string &name);
-
   const Type *getReturnType() const;           // Return the type of the ret val
   const FunctionType *getFunctionType() const; // Return the FunctionType for me
 


Index: llvm/include/llvm/GlobalVariable.h
diff -u llvm/include/llvm/GlobalVariable.h:1.31 llvm/include/llvm/GlobalVariable.h:1.32
--- llvm/include/llvm/GlobalVariable.h:1.31	Sat Mar  5 12:59:36 2005
+++ llvm/include/llvm/GlobalVariable.h	Sat Mar  5 13:51:20 2005
@@ -51,9 +51,6 @@
 		 Constant *Initializer = 0, const std::string &Name = "",
                  Module *Parent = 0);
 
-  // Specialize setName to handle symbol table majik.
-  virtual void setName(const std::string &name);
-
   /// isExternal - Is this global variable lacking an initializer?  If so, the
   /// global variable is defined in some other translation unit, and is thus
   /// externally defined here.


Index: llvm/include/llvm/Instruction.h
diff -u llvm/include/llvm/Instruction.h:1.64 llvm/include/llvm/Instruction.h:1.65
--- llvm/include/llvm/Instruction.h:1.64	Sat Mar  5 12:59:36 2005
+++ llvm/include/llvm/Instruction.h	Sat Mar  5 13:51:20 2005
@@ -54,9 +54,6 @@
     assert(Parent == 0 && "Instruction still linked in the program!");
   }
 
-  // Specialize setName to handle symbol table majik.
-  virtual void setName(const std::string &name);
-  
   /// mayWriteToMemory - Return true if this instruction may modify memory.
   ///
   virtual bool mayWriteToMemory() const { return false; }


Index: llvm/include/llvm/Value.h
diff -u llvm/include/llvm/Value.h:1.72 llvm/include/llvm/Value.h:1.73
--- llvm/include/llvm/Value.h:1.72	Sat Mar  5 12:59:36 2005
+++ llvm/include/llvm/Value.h	Sat Mar  5 13:51:20 2005
@@ -75,9 +75,7 @@
   inline bool               hasName() const { return !Name.empty(); }
   inline const std::string &getName() const { return Name; }
 
-  virtual void setName(const std::string &name) {
-    Name = name;
-  }
+  void setName(const std::string &name);
   
   /// replaceAllUsesWith - Go through the uses list for this definition and make
   /// each use point to "V" instead of "this".  After this completes, 'this's