[llvm-commits] CVS: llvm/lib/Target/X86/X86ISelPattern.cpp

Chris Lattner lattner at cs.uiuc.edu
Fri Jan 21 11:46:54 PST 2005



Changes in directory llvm/lib/Target/X86:

X86ISelPattern.cpp updated: 1.83 -> 1.84
---
Log message:

Fix a FIXME: realize that argument stores are all independent (don't alias)


---
Diffs of the changes:  (+7 -6)

Index: llvm/lib/Target/X86/X86ISelPattern.cpp
diff -u llvm/lib/Target/X86/X86ISelPattern.cpp:1.83 llvm/lib/Target/X86/X86ISelPattern.cpp:1.84
--- llvm/lib/Target/X86/X86ISelPattern.cpp:1.83	Thu Jan 20 12:53:00 2005
+++ llvm/lib/Target/X86/X86ISelPattern.cpp	Fri Jan 21 13:46:38 2005
@@ -196,6 +196,8 @@
     unsigned ArgOffset = 0;
     SDOperand StackPtr = DAG.getCopyFromReg(X86::ESP, MVT::i32,
                                             DAG.getEntryNode());
+    std::vector<SDOperand> Stores;
+
     for (unsigned i = 0, e = Args.size(); i != e; ++i) {
       unsigned ArgReg;
       SDOperand PtrOff = DAG.getConstant(ArgOffset, getPointerTy());
@@ -216,20 +218,19 @@
         // FALL THROUGH
       case MVT::i32:
       case MVT::f32:
-        // FIXME: Note that all of these stores are independent of each other.
-        Chain = DAG.getNode(ISD::STORE, MVT::Other, Chain,
-                            Args[i].first, PtrOff);
+        Stores.push_back(DAG.getNode(ISD::STORE, MVT::Other, Chain,
+                                     Args[i].first, PtrOff));
         ArgOffset += 4;
         break;
       case MVT::i64:
       case MVT::f64:
-        // FIXME: Note that all of these stores are independent of each other.
-        Chain = DAG.getNode(ISD::STORE, MVT::Other, Chain,
-                            Args[i].first, PtrOff);
+        Stores.push_back(DAG.getNode(ISD::STORE, MVT::Other, Chain,
+                                     Args[i].first, PtrOff));
         ArgOffset += 8;
         break;
       }
     }
+    Chain = DAG.getNode(ISD::TokenFactor, MVT::Other, Stores);
   }
 
   std::vector<MVT::ValueType> RetVals;






More information about the llvm-commits mailing list