[llvm-commits] CVS: llvm/lib/System/Win32/Path.cpp Program.cpp TimeValue.cpp

[Jeff Cohen]

Changes in directory llvm/lib/System/Win32:

Path.cpp updated: 1.13 -> 1.14
Program.cpp updated: 1.7 -> 1.8
TimeValue.cpp updated: 1.4 -> 1.5
---
Log message:

Implement Win32 Path::getStatusInfo(), TimeValue::toString()

---
Diffs of the changes:  (+50 -9)

Index: llvm/lib/System/Win32/Path.cpp
diff -u llvm/lib/System/Win32/Path.cpp:1.13 llvm/lib/System/Win32/Path.cpp:1.14
--- llvm/lib/System/Win32/Path.cpp:1.13	Mon Dec 13 13:59:50 2004
+++ llvm/lib/System/Win32/Path.cpp	Mon Dec 13 23:26:43 2004
@@ -287,13 +287,49 @@
   return path.substr(pos+1);
 }
 
+void
+Path::getStatusInfo(StatusInfo& info) const {
+  WIN32_FILE_ATTRIBUTE_DATA fi;
+  if (!GetFileAttributesEx(path.c_str(), GetFileExInfoStandard, &fi))
+    ThrowError(std::string(path) + ": Can't get status: ");
+
+  info.fileSize = fi.nFileSizeHigh;
+  info.fileSize <<= 32;
+  info.fileSize += fi.nFileSizeLow;
+
+  info.mode = 0777;    // Not applicable to Windows, so...
+  info.user = 9999;    // Not applicable to Windows, so...
+  info.group = 9999;   // Not applicable to Windows, so...
+
+  __int64 ft = *reinterpret_cast<__int64*>(&fi.ftLastWriteTime);
+  info.modTime.fromWin32Time(ft);
+
+  info.isDir = fi.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY;
+  if (info.isDir && path[path.length() - 1] != '/')
+    path += '/';
+  else if (!info.isDir && path[path.length() - 1] == '/')
+    path.erase(path.length() - 1);
+}
+
 void Path::makeReadable() {
+  // All files are readable on Windows (ignoring security attributes).
 }
 
 void Path::makeWriteable() {
+  DWORD attr = GetFileAttributes(path.c_str());
+
+  // If it doesn't exist, we're done.
+  if (attr == INVALID_FILE_ATTRIBUTES)
+    return;
+
+  if (attr & FILE_ATTRIBUTE_READONLY) {
+    if (!SetFileAttributes(path.c_str(), attr & ~FILE_ATTRIBUTE_READONLY))
+      ThrowError(std::string(path) + ": Can't make file writable: ");
+  }
 }
 
 void Path::makeExecutable() {
+  // All files are executable on Windows (ignoring security attributes).
 }
 
 bool


Index: llvm/lib/System/Win32/Program.cpp
diff -u llvm/lib/System/Win32/Program.cpp:1.7 llvm/lib/System/Win32/Program.cpp:1.8
--- llvm/lib/System/Win32/Program.cpp:1.7	Mon Dec 13 22:18:51 2004
+++ llvm/lib/System/Win32/Program.cpp	Mon Dec 13 23:26:43 2004
@@ -70,7 +70,7 @@
 int 
 Program::ExecuteAndWait(const Path& path, 
                         const std::vector<std::string>& args,
-                        const char** env) {
+                        const char** envp) {
   if (!path.executable())
     throw path.toString() + " is not executable"; 
 
@@ -125,9 +125,8 @@
   PROCESS_INFORMATION pi;
   memset(&pi, 0, sizeof(pi));
 
-  LPVOID lpEnvironment = envp;
   if (!CreateProcess(path.c_str(), command, NULL, NULL, FALSE, 0,
-                     lpEnvironment, NULL, &si, &pi))
+                     envp, NULL, &si, &pi))
   {
     ThrowError(std::string("Couldn't execute program '") + 
                path.toString() + "'");


Index: llvm/lib/System/Win32/TimeValue.cpp
diff -u llvm/lib/System/Win32/TimeValue.cpp:1.4 llvm/lib/System/Win32/TimeValue.cpp:1.5
--- llvm/lib/System/Win32/TimeValue.cpp:1.4	Tue Nov 16 00:22:17 2004
+++ llvm/lib/System/Win32/TimeValue.cpp	Mon Dec 13 23:26:43 2004
@@ -12,6 +12,7 @@
 //===----------------------------------------------------------------------===//
 
 #include "Win32.h"
+#include <time.h>
 
 namespace llvm {
 using namespace sys;
@@ -21,17 +22,22 @@
 //===----------------------------------------------------------------------===//
 
 TimeValue TimeValue::now() {
-  __int64 ft;
+  uint64_t ft;
   GetSystemTimeAsFileTime(reinterpret_cast<FILETIME *>(&ft));
 
-  return TimeValue(
-    static_cast<TimeValue::SecondsType>( ft / 10000000 +
-      Win32ZeroTime.seconds_ ),
-    static_cast<TimeValue::NanoSecondsType>( (ft % 10000000) * 100) );
+  TimeValue t(0, 0);
+  t.fromWin32Time(ft);
+  return t;
 }
 
 std::string TimeValue::toString() const {
-  return "Don't know how to conver time on Win32";
+  // Alas, asctime is not re-entrant on Windows...
+
+  __time64_t ourTime = this->toEpochTime();
+  char* buffer = ::asctime(::_localtime64(&ourTime));
+
+  std::string result(buffer);
+  return result.substr(0,24);
 }
 
 // vim: sw=2 smartindent smarttab tw=80 autoindent expandtab