[llvm-commits] CVS: llvm/lib/Target/PowerPC/PPC32CodeEmitter.cpp

[Chris Lattner]

Changes in directory llvm/lib/Target/PowerPC:

PPC32CodeEmitter.cpp updated: 1.21 -> 1.22
---
Log message:

Get constant pools working.  This fixes even more programs, allowing us to
pass 24/42 in UnitTests (up from 20).


---
Diffs of the changes:  (+10 -10)

Index: llvm/lib/Target/PowerPC/PPC32CodeEmitter.cpp
diff -u llvm/lib/Target/PowerPC/PPC32CodeEmitter.cpp:1.21 llvm/lib/Target/PowerPC/PPC32CodeEmitter.cpp:1.22
--- llvm/lib/Target/PowerPC/PPC32CodeEmitter.cpp:1.21	Tue Nov 23 19:35:12 2004
+++ llvm/lib/Target/PowerPC/PPC32CodeEmitter.cpp	Tue Nov 23 19:56:12 2004
@@ -199,6 +199,7 @@
     } else {
       assert(0 && "Unknown instruction for relocation!");
     }
+    assert(MovePCtoLROffset && "MovePCtoLR not seen yet?");
     MCE.addRelocation(MachineRelocation(MCE.getCurrentPCOffset(),
                                         Reloc, MO.getGlobal(),
                                         -((intptr_t)MovePCtoLROffset+4)));
@@ -208,27 +209,26 @@
     BBRefs.push_back(std::make_pair(BB, CurrPC));
   } else if (MO.isConstantPoolIndex()) {
     unsigned index = MO.getConstantPoolIndex();
-    rv = MCE.getConstantPoolEntryAddress(index);
-  } else {
-    std::cerr << "ERROR: Unknown type of MachineOperand: " << MO << "\n";
-    abort();
-  }
-
-  // Special treatment for global symbols: constants and vars
-  if ((MO.isConstantPoolIndex() || MO.isGlobalAddress()) &&
-      MI.getOpcode() != PPC::CALLpcrel) {
-    unsigned Opcode = MI.getOpcode();
     assert(MovePCtoLROffset && "MovePCtoLR not seen yet?");
+    rv = MCE.getConstantPoolEntryAddress(index) - (intptr_t)MovePCtoLROffset-4;
 
+    unsigned Opcode = MI.getOpcode();
     if (Opcode == PPC::LOADHiAddr) {
       // LoadHiAddr wants hi16(addr - &MovePCtoLR)
+      if ((short)rv < 0) rv += 1 << 16;
       rv >>= 16;
     } else if (Opcode == PPC::LWZ || Opcode == PPC::LA ||
                Opcode == PPC::LFS || Opcode == PPC::LFD) {
       // These load opcodes want lo16(addr - &MovePCtoLR)
       rv &= 0xffff;
+    } else {
+      assert(0 && "Unknown constant pool using instruction!");
     }
+  } else {
+    std::cerr << "ERROR: Unknown type of MachineOperand: " << MO << "\n";
+    abort();
   }
+
   return rv;
 }