[llvm-commits] CVS: llvm/lib/Support/CommandLine.cpp

Reid Spencer reid at x10sys.com
Mon Nov 15 22:12:03 PST 2004



Changes in directory llvm/lib/Support:

CommandLine.cpp updated: 1.52 -> 1.53
---
Log message:

Per code review:
*Implement/Document the cl::extrahelp feature instead of the MoreHelp ptr.


---
Diffs of the changes:  (+24 -5)

Index: llvm/lib/Support/CommandLine.cpp
diff -u llvm/lib/Support/CommandLine.cpp:1.52 llvm/lib/Support/CommandLine.cpp:1.53
--- llvm/lib/Support/CommandLine.cpp:1.52	Sun Nov 14 16:04:00 2004
+++ llvm/lib/Support/CommandLine.cpp	Tue Nov 16 00:11:52 2004
@@ -838,7 +838,15 @@
 // If this variable is set, it is a pointer to a function that the user wants
 // us to call after we print out the help info. Basically a hook to allow
 // additional help to be printed.
-void (*cl::MoreHelp)() = 0;
+static  std::vector<const char*>* MoreHelp = 0;
+
+extrahelp::extrahelp(const char* Help)
+  : morehelp(Help) {
+  if (!MoreHelp) {
+    MoreHelp = new std::vector<const char*>;
+  }
+  MoreHelp->push_back(Help);
+}
 
 namespace {
 
@@ -913,11 +921,16 @@
     for (unsigned i = 0, e = Options.size(); i != e; ++i)
       Options[i].second->printOptionInfo(MaxArgLen);
 
-    // Call the user's hook so help output can be extended.
-    if (MoreHelp != 0)
-      (*MoreHelp)();
+    // Print any extra help the user has declared. If MoreHelp is not null,
+    // then the user used at least one cl::extrahelp instance to provide
+    // additional help. We just print it out now.
+    if (MoreHelp != 0) {
+      for (std::vector<const char *>::iterator I = MoreHelp->begin(),
+           E = MoreHelp->end(); I != E; ++I)
+        std::cerr << *I;
+    }
 
-    // Halt the program if help information is printed
+    // Halt the program since help information was printed
     exit(1);
   }
 };
@@ -954,4 +967,10 @@
 VersOp("version", cl::desc("display the version"), 
     cl::location(VersionPrinterInstance), cl::ValueDisallowed);
 
+
 } // End anonymous namespace
+
+// Utility function for printing the help message.
+void cl::PrintHelpMessage() {
+  NormalPrinter = true;
+}






More information about the llvm-commits mailing list