[llvm-commits] CVS: llvm/lib/Transforms/Scalar/TailDuplication.cpp

[Chris Lattner]

Changes in directory llvm/lib/Transforms/Scalar:

TailDuplication.cpp updated: 1.25 -> 1.26
---
Log message:

Speed up the tail duplication pass on the testcase below from 68.2s to 1.23s:
#define CL0(a) case a: f(); goto c;
 #define CL1(a) CL0(a##0) CL0(a##1) CL0(a##2) CL0(a##3) CL0(a##4) CL0(a##5) \
 CL0(a##6) CL0(a##7) CL0(a##8) CL0(a##9)
 #define CL2(a) CL1(a##0) CL1(a##1) CL1(a##2) CL1(a##3) CL1(a##4) CL1(a##5) \
 CL1(a##6) CL1(a##7) CL1(a##8) CL1(a##9)
 #define CL3(a) CL2(a##0) CL2(a##1) CL2(a##2) CL2(a##3) CL2(a##4) CL2(a##5) \
 CL2(a##6) CL2(a##7) CL2(a##8) CL2(a##9)
 #define CL4(a) CL3(a##0) CL3(a##1) CL3(a##2) CL3(a##3) CL3(a##4) CL3(a##5) \
 CL3(a##6) CL3(a##7) CL3(a##8) CL3(a##9)

 void f();

 void a() {
     int b;
  c: switch (b) {
         CL4(1)
     }
 }

This comes from GCC PR 15524: http://llvm.cs.uiuc.edu/PR15524 



---
Diffs of the changes:  (+8 -3)

Index: llvm/lib/Transforms/Scalar/TailDuplication.cpp
diff -u llvm/lib/Transforms/Scalar/TailDuplication.cpp:1.25 llvm/lib/Transforms/Scalar/TailDuplication.cpp:1.26
--- llvm/lib/Transforms/Scalar/TailDuplication.cpp:1.25	Tue Oct  5 22:27:37 2004
+++ llvm/lib/Transforms/Scalar/TailDuplication.cpp	Mon Nov  1 01:05:07 2004
@@ -114,9 +114,14 @@
   // with a single successor if the block has many other predecessors.  This can
   // cause an N^2 explosion in CFG edges (and PHI node entries), as seen in
   // cases that have a large number of indirect gotos.
-  if (DTI->getNumSuccessors() > 8)
-    if (std::distance(PI, PE) * DTI->getNumSuccessors() > 128)
-      return false;
+  unsigned NumSuccs = DTI->getNumSuccessors();
+  if (NumSuccs > 8) {
+    unsigned TooMany = 128;
+    if (NumSuccs >= TooMany) return false;
+    TooMany = TooMany/NumSuccs;
+    for (; PI != PE; ++PI)
+      if (TooMany-- == 0) return false;
+  }
 
   return true;  
 }