[llvm-commits] CVS: llvm/lib/AsmParser/llvmAsmParser.y

[Chris Lattner]

Changes in directory llvm/lib/AsmParser:

llvmAsmParser.y updated: 1.186 -> 1.187

---
Log message:

* Fairly substantial change.  Instead of creating new globalvariables, then
  replaceAllUsesWith'ing any forward references, just use the forward 
  reference if it exists.

This introduces GetForwardRefForGlobal, which will eventually completely
replace the horrible DeclareNewGlobalValue function.



---
Diffs of the changes:  (+49 -14)

Index: llvm/lib/AsmParser/llvmAsmParser.y
diff -u llvm/lib/AsmParser/llvmAsmParser.y:1.186 llvm/lib/AsmParser/llvmAsmParser.y:1.187
--- llvm/lib/AsmParser/llvmAsmParser.y:1.186	Wed Jul 14 15:42:57 2004
+++ llvm/lib/AsmParser/llvmAsmParser.y	Wed Jul 14 16:44:00 2004
@@ -112,6 +112,21 @@
   }
 
 
+  // GetForwardRefForGlobal - Check to see if there is a forward reference
+  // for this global.  If so, remove it from the GlobalRefs map and return it.
+  // If not, just return null.
+  GlobalValue *GetForwardRefForGlobal(const PointerType *PTy, ValID ID) {
+    // Check to see if there is a forward reference to this global variable...
+    // if there is, eliminate it and patch the reference to use the new def'n.
+    GlobalRefsType::iterator I = GlobalRefs.find(std::make_pair(PTy, ID));
+    GlobalValue *Ret = 0;
+    if (I != GlobalRefs.end()) {
+      Ret = I->second;
+      GlobalRefs.erase(I);
+    }
+    return Ret;
+  }
+
   // DeclareNewGlobalValue - Called every time a new GV has been defined.  This
   // is used to remove things from the forward declaration map, resolving them
   // to the correct thing as needed.
@@ -626,15 +641,30 @@
     }
   }
 
-  GlobalVariable *GV = new GlobalVariable(Ty, isConstantGlobal, Linkage,
-                                          Initializer, Name, 
-                                          CurModule.CurrentModule);
-  int Slot = InsertValue(GV, CurModule.Values);
-  
-  if (Slot != -1) {
-    CurModule.DeclareNewGlobalValue(GV, ValID::create(Slot));
+  const PointerType *PTy = PointerType::get(Ty); 
+
+  // See if this global value was forward referenced.  If so, recycle the
+  // object.
+  ValID ID; 
+  if (!Name.empty()) {
+    ID = ValID::create((char*)Name.c_str());
+  } else {
+    ID = ValID::create((int)CurModule.Values[PTy].size());
+  }
+
+  if (GlobalValue *FWGV = CurModule.GetForwardRefForGlobal(PTy, ID)) {
+    // Move the global to the end of the list, from whereever it was 
+    // previously inserted.
+    GlobalVariable *GV = cast<GlobalVariable>(FWGV);
+    CurModule.CurrentModule->getGlobalList().remove(GV);
+    CurModule.CurrentModule->getGlobalList().push_back(GV);
+    GV->setInitializer(Initializer);
+    GV->setLinkage(Linkage);
+    GV->setConstant(isConstantGlobal);
   } else {
-    CurModule.DeclareNewGlobalValue(GV, ValID::create((char*)Name.c_str()));
+    // Otherwise there is no existing GV to use, create one now.
+    new GlobalVariable(Ty, isConstantGlobal, Linkage, Initializer, Name, 
+                       CurModule.CurrentModule);
   }
 }
 
@@ -1261,15 +1291,20 @@
 	V = I->second;             // Placeholder already exists, use it...
         $2.destroy();
       } else {
+        std::string Name;
+
+        /// FIXME: We shouldn't be creating global vars as forward refs for
+        /// functions at all here!
+        if (!isa<FunctionType>(PT->getElementType()))
+          if ($2.Type == ValID::NameVal) Name = $2.Name;
+
 	// Create a placeholder for the global variable reference...
-	GlobalVariable *GV = new GlobalVariable(PT->getElementType(),
-                                                false,
-                                                GlobalValue::ExternalLinkage);
+	GlobalVariable *GV = new GlobalVariable(PT->getElementType(), false,
+                                                GlobalValue::ExternalLinkage,0,
+                                                Name, CurModule.CurrentModule);
+
 	// Keep track of the fact that we have a forward ref to recycle it
 	CurModule.GlobalRefs.insert(std::make_pair(std::make_pair(PT, $2), GV));
-
-	// Must temporarily push this value into the module table...
-	CurModule.CurrentModule->getGlobalList().push_back(GV);
 	V = GV;
       }
     }