[llvm-commits] CVS: llvm/lib/Target/X86/InstSelectSimple.cpp
Chris Lattner
lattner at cs.uiuc.edu
Mon Jun 28 19:15:01 PDT 2004
Changes in directory llvm/lib/Target/X86:
InstSelectSimple.cpp updated: 1.268 -> 1.269
---
Log message:
Fix a regression from r1.224. In particular, codegen a cast from double ->
float as a truncation by going through memory. This truncation was being
skipped, which caused 175.vpr to fail after aggressive register promotion.
---
Diffs of the changes: (+11 -4)
Index: llvm/lib/Target/X86/InstSelectSimple.cpp
diff -u llvm/lib/Target/X86/InstSelectSimple.cpp:1.268 llvm/lib/Target/X86/InstSelectSimple.cpp:1.269
--- llvm/lib/Target/X86/InstSelectSimple.cpp:1.268 Sun Jun 20 02:47:25 2004
+++ llvm/lib/Target/X86/InstSelectSimple.cpp Mon Jun 28 19:14:38 2004
@@ -405,8 +405,10 @@
BuildMI(*MBB, IPt, X86::MOV32ri, 1, Reg).addGlobalAddress(GV);
return Reg;
} else if (CastInst *CI = dyn_cast<CastInst>(V)) {
- // Do not emit noop casts at all.
- if (getClassB(CI->getType()) == getClassB(CI->getOperand(0)->getType()))
+ // Do not emit noop casts at all, unless it's a double -> float cast.
+ if (getClassB(CI->getType()) == getClassB(CI->getOperand(0)->getType()) &&
+ (CI->getType() != Type::FloatTy ||
+ CI->getOperand(0)->getType() != Type::DoubleTy))
return getReg(CI->getOperand(0), MBB, IPt);
} else if (AllocaInst *AI = dyn_castFixedAlloca(V)) {
// If the alloca address couldn't be folded into the instruction addressing,
@@ -3116,8 +3118,13 @@
unsigned DestClass = getClassB(CI.getType());
// Noop casts are not emitted: getReg will return the source operand as the
// register to use for any uses of the noop cast.
- if (DestClass == SrcClass)
- return;
+ if (DestClass == SrcClass) {
+ // The only detail in this plan is that casts from double -> float are
+ // truncating operations that we have to codegen through memory (despite
+ // the fact that the source/dest registers are the same class).
+ if (CI.getType() != Type::FloatTy || Op->getType() != Type::DoubleTy)
+ return;
+ }
// If this is a cast from a 32-bit integer to a Long type, and the only uses
// of the case are GEP instructions, then the cast does not need to be
More information about the llvm-commits
mailing list