[llvm-commits] CVS: llvm/lib/Transforms/Scalar/LoopUnroll.cpp

[Chris Lattner]

Changes in directory llvm/lib/Transforms/Scalar:

LoopUnroll.cpp updated: 1.1 -> 1.2

---
Log message:

Fix a bug: this does not preserve the CFG!

While we're at it, add support for updating loop information correctly.


---
Diffs of the changes:  (+20 -4)

Index: llvm/lib/Transforms/Scalar/LoopUnroll.cpp
diff -u llvm/lib/Transforms/Scalar/LoopUnroll.cpp:1.1 llvm/lib/Transforms/Scalar/LoopUnroll.cpp:1.2
--- llvm/lib/Transforms/Scalar/LoopUnroll.cpp:1.1	Sun Apr 18 00:20:17 2004
+++ llvm/lib/Transforms/Scalar/LoopUnroll.cpp	Sun Apr 18 00:38:37 2004
@@ -47,9 +47,9 @@
     /// loop preheaders be inserted into the CFG...
     ///
     virtual void getAnalysisUsage(AnalysisUsage &AU) const {
-      AU.setPreservesCFG();
       AU.addRequiredID(LoopSimplifyID);
       AU.addRequired<LoopInfo>();
+      AU.addPreserved<LoopInfo>();
     }
   };
   RegisterOpt<LoopUnroll> X("loop-unroll", "Unroll loops");
@@ -61,8 +61,11 @@
   bool Changed = false;
   LI = &getAnalysis<LoopInfo>();
 
-  for (LoopInfo::iterator I = LI->begin(), E = LI->end(); I != E; ++I)
-    Changed |= visitLoop(*I);
+  // Transform all the top-level loops.  Copy the loop list so that the child
+  // can update the loop tree if it needs to delete the loop.
+  std::vector<Loop*> SubLoops(LI->begin(), LI->end());
+  for (unsigned i = 0, e = SubLoops.size(); i != e; ++i)
+    Changed |= visitLoop(SubLoops[i]);
 
   return Changed;
 }
@@ -238,7 +241,20 @@
     }
   }
 
-  // FIXME: Should update analyses
+  // Update the loop information for this loop.
+  Loop *Parent = L->getParentLoop();
+
+  // Move all of the basic blocks in the loop into the parent loop.
+  LI->changeLoopFor(BB, Parent);
+
+  // Remove the loop from the parent.
+  if (Parent)
+    delete Parent->removeChildLoop(std::find(Parent->begin(), Parent->end(),L));
+  else
+    delete LI->removeLoop(std::find(LI->begin(), LI->end(), L));
+
+
+  // FIXME: Should update dominator analyses
 
   // FIXME: Should fold into preheader and exit block