[llvm-commits] CVS: llvm/lib/Transforms/Scalar/IndVarSimplify.cpp

[Chris Lattner]

Changes in directory llvm/lib/Transforms/Scalar:

IndVarSimplify.cpp updated: 1.54 -> 1.55

---
Log message:

Fix a bug in the previous checkin: if the exit block is not the same as
the back-edge block, we must check the preincremented value.


---
Diffs of the changes:  (+22 -6)

Index: llvm/lib/Transforms/Scalar/IndVarSimplify.cpp
diff -u llvm/lib/Transforms/Scalar/IndVarSimplify.cpp:1.54 llvm/lib/Transforms/Scalar/IndVarSimplify.cpp:1.55
--- llvm/lib/Transforms/Scalar/IndVarSimplify.cpp:1.54	Thu Apr 15 10:21:43 2004
+++ llvm/lib/Transforms/Scalar/IndVarSimplify.cpp	Thu Apr 15 15:26:22 2004
@@ -209,13 +209,29 @@
   if (Instruction *Cond = dyn_cast<Instruction>(BI->getCondition()))
     InstructionsToDelete.insert(Cond);
 
-  // The IterationCount expression contains the number of times that the
-  // backedge actually branches to the loop header.  This is one less than the
-  // number of times the loop executes, so add one to it.
-  Constant *OneC = ConstantInt::get(IterationCount->getType(), 1);
-  SCEVHandle TripCount=SCEVAddExpr::get(IterationCount, SCEVUnknown::get(OneC));
+  // If the exiting block is not the same as the backedge block, we must compare
+  // against the preincremented value, otherwise we prefer to compare against
+  // the post-incremented value.
+  BasicBlock *Header = L->getHeader();
+  pred_iterator HPI = pred_begin(Header);
+  assert(HPI != pred_end(Header) && "Loop with zero preds???");
+  if (!L->contains(*HPI)) ++HPI;
+  assert(HPI != pred_end(Header) && L->contains(*HPI) &&
+         "No backedge in loop?");
 
-  Value *IndVar = L->getCanonicalInductionVariableIncrement();
+  SCEVHandle TripCount = IterationCount;
+  Value *IndVar;
+  if (*HPI == ExitingBlock) {
+    // The IterationCount expression contains the number of times that the
+    // backedge actually branches to the loop header.  This is one less than the
+    // number of times the loop executes, so add one to it.
+    Constant *OneC = ConstantInt::get(IterationCount->getType(), 1);
+    TripCount = SCEVAddExpr::get(IterationCount, SCEVUnknown::get(OneC));
+    IndVar = L->getCanonicalInductionVariableIncrement();
+  } else {
+    // We have to use the preincremented value...
+    IndVar = L->getCanonicalInductionVariable();
+  }
 
   // Expand the code for the iteration count into the preheader of the loop.
   BasicBlock *Preheader = L->getLoopPreheader();