[llvm-commits] CVS: llvm/lib/Target/X86/Printer.cpp X86.td X86InstrInfo.h

[Chris Lattner]

Changes in directory llvm/lib/Target/X86:

Printer.cpp updated: 1.96 -> 1.97
X86.td updated: 1.10 -> 1.11
X86InstrInfo.h updated: 1.38 -> 1.39

---
Log message:

Add support for the printImplicitDefsBefore flag


---
Diffs of the changes:  (+38 -7)

Index: llvm/lib/Target/X86/Printer.cpp
diff -u llvm/lib/Target/X86/Printer.cpp:1.96 llvm/lib/Target/X86/Printer.cpp:1.97
--- llvm/lib/Target/X86/Printer.cpp:1.96	Thu Apr  8 15:31:46 2004
+++ llvm/lib/Target/X86/Printer.cpp	Tue Apr 13 12:18:39 2004
@@ -105,6 +105,7 @@
     }
 
     void printImplUsesBefore(const TargetInstrDescriptor &Desc);
+    bool printImplDefsBefore(const TargetInstrDescriptor &Desc);
     bool printImplUsesAfter(const TargetInstrDescriptor &Desc, const bool LC);
     bool printImplDefsAfter(const TargetInstrDescriptor &Desc, const bool LC);
     void printMachineInstruction(const MachineInstr *MI);
@@ -544,6 +545,30 @@
   }
 }
 
+/// printImplDefsBefore - Emit the implicit-def registers for the instruction
+/// described by DESC, if its PrintImplUsesBefore flag is set.  Return true if
+/// we printed any registers.
+///
+bool Printer::printImplDefsBefore(const TargetInstrDescriptor &Desc) {
+  bool Printed = false;
+  const MRegisterInfo &RI = *TM.getRegisterInfo();
+  if (Desc.TSFlags & X86II::PrintImplDefsBefore) {
+    const unsigned *p = Desc.ImplicitDefs;
+    if (*p) {
+      O << (Printed ? ", %" : "%") << RI.get (*p).Name;
+      Printed = true;
+      ++p;
+    }
+    while (*p) {
+      // Bug Workaround: See note in Printer::doInitialization about %.
+      O << ", %" << RI.get(*p).Name;
+      ++p;
+    }
+  }
+  return Printed;
+}
+
+
 /// printImplUsesAfter - Emit the implicit-use registers for the instruction
 /// described by DESC, if its PrintImplUsesAfter flag is set.
 ///
@@ -655,22 +680,25 @@
 
   case X86II::RawFrm:
   {
-    bool LeadingComma = false;
-
     // The accepted forms of Raw instructions are:
     //   1. nop     - No operand required
     //   2. jmp foo - PC relative displacement operand
     //   3. call bar - GlobalAddress Operand or External Symbol Operand
+    //   4. in AL, imm - Immediate operand
     //
     assert(MI->getNumOperands() == 0 ||
            (MI->getNumOperands() == 1 &&
 	    (MI->getOperand(0).isPCRelativeDisp() ||
 	     MI->getOperand(0).isGlobalAddress() ||
-	     MI->getOperand(0).isExternalSymbol())) &&
+	     MI->getOperand(0).isExternalSymbol() ||
+             MI->getOperand(0).isImmediate())) &&
            "Illegal raw instruction!");
     O << TII.getName(MI->getOpcode()) << " ";
 
+    bool LeadingComma = printImplDefsBefore(Desc);
+
     if (MI->getNumOperands() == 1) {
+      if (LeadingComma) O << ", ";
       printOp(MI->getOperand(0), true); // Don't print "OFFSET"...
       LeadingComma = true;
     }


Index: llvm/lib/Target/X86/X86.td
diff -u llvm/lib/Target/X86/X86.td:1.10 llvm/lib/Target/X86/X86.td:1.11
--- llvm/lib/Target/X86/X86.td:1.10	Thu Apr  8 15:31:47 2004
+++ llvm/lib/Target/X86/X86.td	Tue Apr 13 12:18:39 2004
@@ -41,6 +41,7 @@
                        "FPFormBits",
                        "printImplicitUsesAfter", 
                        "printImplicitUsesBefore",
+                       "printImplicitDefsBefore",
                        "printImplicitDefsAfter",
                        "Opcode"];
   let TSFlagsShifts = [0,
@@ -52,7 +53,8 @@
                        18,
                        19,
                        20,
-                       21];
+                       21,
+                       22];
 }
 
 def X86 : Target {


Index: llvm/lib/Target/X86/X86InstrInfo.h
diff -u llvm/lib/Target/X86/X86InstrInfo.h:1.38 llvm/lib/Target/X86/X86InstrInfo.h:1.39
--- llvm/lib/Target/X86/X86InstrInfo.h:1.38	Thu Apr  8 15:31:47 2004
+++ llvm/lib/Target/X86/X86InstrInfo.h	Tue Apr 13 12:18:39 2004
@@ -171,11 +171,12 @@
 
     // PrintImplDefsAfter - Print out implicit defs in the assembly output
     // after the normal operands.
-    PrintImplDefsAfter = 1 << 20,
+    PrintImplDefsBefore = 1 << 20,
+    PrintImplDefsAfter  = 1 << 21,
 
-    OpcodeShift   = 21,
+    OpcodeShift   = 22,
     OpcodeMask    = 0xFF << OpcodeShift,
-    // Bits 26 -> 31 are unused
+    // Bits 27 -> 31 are unused
   };
 }