[llvm-commits] CVS: llvm/lib/Transforms/ExprTypeConvert.cpp LevelRaise.cpp TransformInternals.cpp
Chris Lattner
lattner at cs.uiuc.edu
Sun Apr 4 20:29:19 PDT 2004
Changes in directory llvm/lib/Transforms:
ExprTypeConvert.cpp updated: 1.90 -> 1.91
LevelRaise.cpp updated: 1.95 -> 1.96
TransformInternals.cpp updated: 1.44 -> 1.45
---
Log message:
Support getelementptr instructions which use uint's to index into structure
types and can have arbitrary 32- and 64-bit integer types indexing into
sequential types.
---
Diffs of the changes: (+25 -123)
Index: llvm/lib/Transforms/ExprTypeConvert.cpp
diff -u llvm/lib/Transforms/ExprTypeConvert.cpp:1.90 llvm/lib/Transforms/ExprTypeConvert.cpp:1.91
--- llvm/lib/Transforms/ExprTypeConvert.cpp:1.90 Tue Mar 16 13:52:53 2004
+++ llvm/lib/Transforms/ExprTypeConvert.cpp Sun Apr 4 20:28:59 2004
@@ -797,10 +797,13 @@
// stream, so we have to delete it when we're done.
//
if (DataSize != 1) {
- // FIXME, PR82
- TempScale = BinaryOperator::create(Instruction::Mul, Index,
- ConstantSInt::get(Type::LongTy,
- DataSize));
+ Value *CST;
+ if (Index->getType()->isSigned())
+ CST = ConstantSInt::get(Index->getType(), DataSize);
+ else
+ CST = ConstantUInt::get(Index->getType(), DataSize);
+
+ TempScale = BinaryOperator::create(Instruction::Mul, Index, CST);
Index = TempScale;
}
@@ -1012,8 +1015,7 @@
if (const CompositeType *CT = dyn_cast<CompositeType>(LoadedTy)) {
std::vector<Value*> Indices;
- // FIXME, PR82
- Indices.push_back(ConstantSInt::get(Type::LongTy, 0));
+ Indices.push_back(Constant::getNullValue(Type::UIntTy));
unsigned Offset = 0; // No offset, get first leaf.
LoadedTy = getStructOffsetType(CT, Offset, Indices, TD, false);
@@ -1049,8 +1051,7 @@
const StructType *SElTy = cast<StructType>(ElTy);
std::vector<Value*> Indices;
- // FIXME, PR82
- Indices.push_back(Constant::getNullValue(Type::LongTy));
+ Indices.push_back(Constant::getNullValue(Type::UIntTy));
unsigned Offset = 0;
const Type *Ty = getStructOffsetType(ElTy, Offset, Indices, TD,false);
@@ -1079,8 +1080,7 @@
if (isa<StructType>(ValTy)) {
std::vector<Value*> Indices;
- // FIXME: PR82
- Indices.push_back(Constant::getNullValue(Type::LongTy));
+ Indices.push_back(Constant::getNullValue(Type::UIntTy));
unsigned Offset = 0;
ValTy = getStructOffsetType(ValTy, Offset, Indices, TD, false);
@@ -1112,10 +1112,13 @@
if (DataSize != 1) {
// Insert a multiply of the old element type is not a unit size...
- Index = BinaryOperator::create(Instruction::Mul, Index,
- // FIXME: PR82
- ConstantSInt::get(Type::LongTy, DataSize),
- "scale", It);
+ Value *CST;
+ if (Index->getType()->isSigned())
+ CST = ConstantSInt::get(Index->getType(), DataSize);
+ else
+ CST = ConstantUInt::get(Index->getType(), DataSize);
+
+ Index = BinaryOperator::create(Instruction::Mul, Index, CST, "scale", It);
}
// Perform the conversion now...
Index: llvm/lib/Transforms/LevelRaise.cpp
diff -u llvm/lib/Transforms/LevelRaise.cpp:1.95 llvm/lib/Transforms/LevelRaise.cpp:1.96
--- llvm/lib/Transforms/LevelRaise.cpp:1.95 Sun Feb 8 22:37:31 2004
+++ llvm/lib/Transforms/LevelRaise.cpp Sun Apr 4 20:28:59 2004
@@ -370,9 +370,8 @@
// Build the index vector, full of all zeros
std::vector<Value*> Indices;
- Indices.push_back(ConstantSInt::get(Type::LongTy, 0)); // FIXME, PR82
+ Indices.push_back(Constant::getNullValue(Type::UIntTy));
while (CurCTy && !isa<PointerType>(CurCTy)) {
- const Type *IdxType;
if (const StructType *CurSTy = dyn_cast<StructType>(CurCTy)) {
// Check for a zero element struct type... if we have one, bail.
if (CurSTy->getNumElements() == 0) break;
@@ -381,14 +380,12 @@
// offset zero in the struct.
//
ElTy = CurSTy->getElementType(0);
- IdxType = Type::UByteTy; // FIXME when PR82 is fixed.
} else {
ElTy = cast<ArrayType>(CurCTy)->getElementType();
- IdxType = Type::LongTy; // FIXME when PR82 is fixed.
}
// Insert a zero to index through this type...
- Indices.push_back(Constant::getNullValue(IdxType));
+ Indices.push_back(Constant::getNullValue(Type::UIntTy));
// Did we find what we're looking for?
if (ElTy->isLosslesslyConvertibleTo(DestPointedTy)) break;
Index: llvm/lib/Transforms/TransformInternals.cpp
diff -u llvm/lib/Transforms/TransformInternals.cpp:1.44 llvm/lib/Transforms/TransformInternals.cpp:1.45
--- llvm/lib/Transforms/TransformInternals.cpp:1.44 Sun Feb 8 22:37:31 2004
+++ llvm/lib/Transforms/TransformInternals.cpp Sun Apr 4 20:28:59 2004
@@ -35,8 +35,7 @@
(i == SL->MemberOffsets.size()-1 || Offset < SL->MemberOffsets[i+1]));
// Make sure to save the current index...
- // FIXME for PR82
- Indices.push_back(ConstantUInt::get(Type::UByteTy, i));
+ Indices.push_back(ConstantUInt::get(Type::UIntTy, i));
Offset = SL->MemberOffsets[i];
return STy->getContainedType(i);
}
@@ -75,8 +74,10 @@
NextType = ATy->getElementType();
unsigned ChildSize = TD.getTypeSize(NextType);
- // FIXME for PR82
- Indices.push_back(ConstantSInt::get(Type::LongTy, Offset/ChildSize));
+ if (ConstantSInt::isValueValidForType(Type::IntTy, Offset/ChildSize))
+ Indices.push_back(ConstantSInt::get(Type::IntTy, Offset/ChildSize));
+ else
+ Indices.push_back(ConstantSInt::get(Type::LongTy, Offset/ChildSize));
ThisOffset = (Offset/ChildSize)*ChildSize;
} else {
Offset = 0; // Return the offset that we were able to achieve
@@ -99,105 +100,6 @@
std::vector<Value*> &Indices,
const TargetData &TD,
BasicBlock::iterator *BI) {
- const CompositeType *CompTy = dyn_cast<CompositeType>(Ty);
- if (CompTy == 0) return 0;
-
- // See if the cast is of an integer expression that is either a constant,
- // or a value scaled by some amount with a possible offset.
- //
- ExprType Expr = ClassifyExpr(OffsetVal);
-
- // Get the offset and scale values if they exists...
- // A scale of zero with Expr.Var != 0 means a scale of 1.
- //
- int64_t Offset = Expr.Offset ? getConstantValue(Expr.Offset) : 0;
- int64_t Scale = Expr.Scale ? getConstantValue(Expr.Scale) : 0;
-
- if (Expr.Var && Scale == 0) Scale = 1; // Scale != 0 if Expr.Var != 0
-
- // Loop over the Scale and Offset values, filling in the Indices vector for
- // our final getelementptr instruction.
- //
- const Type *NextTy = CompTy;
- do {
- if (!isa<CompositeType>(NextTy))
- return 0; // Type must not be ready for processing...
- CompTy = cast<CompositeType>(NextTy);
-
- if (const StructType *StructTy = dyn_cast<StructType>(CompTy)) {
- // Step into the appropriate element of the structure...
- uint64_t ActualOffset = (Offset < 0) ? 0 : (uint64_t)Offset;
- NextTy = getStructOffsetStep(StructTy, ActualOffset, Indices, TD);
- Offset -= ActualOffset;
- } else {
- const Type *ElTy = cast<SequentialType>(CompTy)->getElementType();
- if (!ElTy->isSized() || (isa<PointerType>(CompTy) && !Indices.empty()))
- return 0; // Type is unreasonable... escape!
- unsigned ElSize = TD.getTypeSize(ElTy);
- if (ElSize == 0) return 0; // Avoid division by zero...
- int64_t ElSizeS = ElSize;
-
- // See if the user is indexing into a different cell of this array...
- if (Scale && (Scale >= ElSizeS || -Scale >= ElSizeS)) {
- // A scale n*ElSize might occur if we are not stepping through
- // array by one. In this case, we will have to insert math to munge
- // the index.
- //
- int64_t ScaleAmt = Scale/ElSizeS;
- if (Scale-ScaleAmt*ElSizeS)
- return 0; // Didn't scale by a multiple of element size, bail out
- Scale = 0; // Scale is consumed
-
- int64_t Index = Offset/ElSize; // is zero unless Offset > ElSize
- Offset -= Index*ElSize; // Consume part of the offset
-
- if (BI) { // Generate code?
- BasicBlock *BB = (*BI)->getParent();
- if (Expr.Var->getType() != Type::LongTy) // FIXME for PR82
- Expr.Var = new CastInst(Expr.Var, Type::LongTy, // FIXME for PR82
- Expr.Var->getName()+"-idxcast", *BI);
-
- if (ScaleAmt && ScaleAmt != 1) {
- // If we have to scale up our index, do so now
- // FIXME for PR82
- Value *ScaleAmtVal = ConstantSInt::get(Type::LongTy, ScaleAmt);
- Expr.Var = BinaryOperator::create(Instruction::Mul, Expr.Var,
- ScaleAmtVal,
- Expr.Var->getName()+"-scale",*BI);
- }
-
- if (Index) { // Add an offset to the index
- // FIXME for PR82
- Value *IndexAmt = ConstantSInt::get(Type::LongTy, Index);
- Expr.Var = BinaryOperator::create(Instruction::Add, Expr.Var,
- IndexAmt,
- Expr.Var->getName()+"-offset",
- *BI);
- }
- }
-
- Indices.push_back(Expr.Var);
- Expr.Var = 0;
- } else if (Offset >= (int64_t)ElSize || -Offset >= (int64_t)ElSize) {
- // Calculate the index that we are entering into the array cell with
- uint64_t Index = Offset/ElSize;
- // FIXME for PR82
- Indices.push_back(ConstantSInt::get(Type::LongTy, Index));
- Offset -= (int64_t)(Index*ElSize); // Consume part of the offset
-
- } else if (isa<ArrayType>(CompTy) || Indices.empty()) {
- // Must be indexing a small amount into the first cell of the array
- // Just index into element zero of the array here.
- //
- // FIXME for PR82
- Indices.push_back(ConstantSInt::get(Type::LongTy, 0));
- } else {
- return 0; // Hrm. wierd, can't handle this case. Bail
- }
- NextTy = ElTy;
- }
- } while (Offset || Scale); // Go until we're done!
-
- return NextTy;
+ return 0;
}
More information about the llvm-commits
mailing list