[llvm-commits] CVS: llvm/tools/bugpoint/BugDriver.h CrashDebugger.cpp Miscompilation.cpp

Chris Lattner lattner at cs.uiuc.edu
Wed Feb 18 15:30:02 PST 2004


Changes in directory llvm/tools/bugpoint:

BugDriver.h updated: 1.26 -> 1.27
CrashDebugger.cpp updated: 1.29 -> 1.30
Miscompilation.cpp updated: 1.27 -> 1.28

---
Log message:

A couple of minor cleanups: don't forward declare private classes, put private
classes in an anon namespace


---
Diffs of the changes:  (+4 -6)

Index: llvm/tools/bugpoint/BugDriver.h
diff -u llvm/tools/bugpoint/BugDriver.h:1.26 llvm/tools/bugpoint/BugDriver.h:1.27
--- llvm/tools/bugpoint/BugDriver.h:1.26	Wed Feb 18 15:24:48 2004
+++ llvm/tools/bugpoint/BugDriver.h	Wed Feb 18 15:29:46 2004
@@ -30,8 +30,6 @@
 class DebugCrashes;
 class ReduceMiscompilingPasses;
 class ReduceMiscompilingFunctions;
-class ReduceCrashingFunctions;
-class ReduceCrashingBlocks;
 
 class CBE;
 class GCC;


Index: llvm/tools/bugpoint/CrashDebugger.cpp
diff -u llvm/tools/bugpoint/CrashDebugger.cpp:1.29 llvm/tools/bugpoint/CrashDebugger.cpp:1.30
--- llvm/tools/bugpoint/CrashDebugger.cpp:1.29	Wed Feb 18 15:24:48 2004
+++ llvm/tools/bugpoint/CrashDebugger.cpp	Wed Feb 18 15:29:46 2004
@@ -144,7 +144,7 @@
 }
 
 
-namespace llvm {
+namespace {
   /// ReduceCrashingBlocks reducer - This works by setting the terminators of
   /// all terminators except the specified basic blocks to a 'ret' instruction,
   /// then running the simplify-cfg pass.  This has the effect of chopping up


Index: llvm/tools/bugpoint/Miscompilation.cpp
diff -u llvm/tools/bugpoint/Miscompilation.cpp:1.27 llvm/tools/bugpoint/Miscompilation.cpp:1.28
--- llvm/tools/bugpoint/Miscompilation.cpp:1.27	Wed Feb 18 15:02:04 2004
+++ llvm/tools/bugpoint/Miscompilation.cpp	Wed Feb 18 15:29:46 2004
@@ -159,7 +159,7 @@
   }
 
   // First step: clone the module for the two halves of the program we want.
-  Module *ToOptimize = CloneModule(BD.Program);
+  Module *ToOptimize = CloneModule(BD.getProgram());
 
   // Second step: Make sure functions & globals are all external so that linkage
   // between the two modules will work.
@@ -231,7 +231,7 @@
   if (!EmitBytecode)
     std::cout << "done.\n";
 
-  delete BD.Program;   // Delete the old "ToOptimize" module
+  delete BD.getProgram();   // Delete the old "ToOptimize" module
   BD.Program = BD.ParseInputFile(BytecodeResult);
 
   if (EmitBytecode) {
@@ -270,7 +270,7 @@
   // output, then 'Funcs' are being misoptimized!
   bool Broken = BD.diffProgram();
 
-  delete BD.Program;  // Delete the hacked up program
+  delete BD.Program;         // Delete the hacked up program
   BD.Program = OldProgram;   // Restore the original
 
   std::cout << (Broken ? " nope.\n" : " yup.\n");





More information about the llvm-commits mailing list