[llvm-commits] CVS: llvm/lib/Bytecode/Reader/ArchiveReader.cpp

[John Criswell]

Changes in directory llvm/lib/Bytecode/Reader:

ArchiveReader.cpp updated: 1.12 -> 1.13

---
Log message:

Reverted back to revision 1.11.  The previous fix doesn't really fix
anything; it just causes the bug to go dormant.



---
Diffs of the changes:  (+3 -12)

Index: llvm/lib/Bytecode/Reader/ArchiveReader.cpp
diff -u llvm/lib/Bytecode/Reader/ArchiveReader.cpp:1.12 llvm/lib/Bytecode/Reader/ArchiveReader.cpp:1.13
--- llvm/lib/Bytecode/Reader/ArchiveReader.cpp:1.12	Sat Dec 20 16:37:29 2003
+++ llvm/lib/Bytecode/Reader/ArchiveReader.cpp	Mon Dec 22 10:22:49 2003
@@ -122,17 +122,8 @@
       while (endp[-1] == ' ')
         --endp;
     }
-
-    //
-    // We now have the beginning and the end of the object name.
-    // Convert this into a dynamically allocated std::string to pass
-    // to the routines that create the Module object.  We do this
-    // (I think) because the created Module object will outlive this function,
-    // but statically declared std::string's won't.
-    //
     std::string MemberName (startp, endp);
-    std::string * FullMemberName;
-    FullMemberName = new std::string (ArchiveName + "(" + MemberName + ")");
+    std::string FullMemberName = ArchiveName + "(" + MemberName + ")";
 
     switch (getObjectType(Hdr, MemberData, MemberSize)) {
     case SVR4LongFilename:
@@ -142,7 +133,7 @@
       break;
     case UserObject: {
       Module *M = ParseBytecodeBuffer(MemberData, MemberSize,
-                                      *(FullMemberName), ErrorStr);
+                                      FullMemberName, ErrorStr);
       if (!M) return true;
       Objects.push_back(M);
       break;
@@ -153,7 +144,7 @@
       break;
     default:
       std::cerr << "ReadArchiveBuffer: WARNING: Skipping unknown file: "
-                << *(FullMemberName) << "\n";
+                << FullMemberName << "\n";
       break;   // Just ignore unknown files.
     }