[llvm-commits] CVS: llvm/lib/VMCore/Verifier.cpp

[Chris Lattner]

Changes in directory llvm/lib/VMCore:

Verifier.cpp updated: 1.72 -> 1.73

---
Log message:

Fix problem Reid was having with external globals and nonexternal linkage


---
Diffs of the changes:  (+2 -3)

Index: llvm/lib/VMCore/Verifier.cpp
diff -u llvm/lib/VMCore/Verifier.cpp:1.72 llvm/lib/VMCore/Verifier.cpp:1.73
--- llvm/lib/VMCore/Verifier.cpp:1.72	Fri Nov 21 14:23:48 2003
+++ llvm/lib/VMCore/Verifier.cpp	Fri Nov 21 14:33:27 2003
@@ -108,8 +108,7 @@
         visitGlobalValue(*I);
 
       for (Module::giterator I = M.gbegin(), E = M.gend(); I != E; ++I)
-        if (I->isExternal() && I->hasInternalLinkage())
-          CheckFailed("Global Variable is external with internal linkage!", I);
+        visitGlobalValue(*I);
 
       // If the module is broken, abort at this time.
       abortIfBroken();
@@ -203,7 +202,7 @@
 
 void Verifier::visitGlobalValue(GlobalValue &GV) {
   Assert1(!GV.isExternal() || GV.hasExternalLinkage(),
-          "Global value has Internal Linkage!", &GV);
+          "Global is external, but doesn't have external linkage!", &GV);
   Assert1(!GV.hasAppendingLinkage() || isa<GlobalVariable>(GV),
           "Only global variables can have appending linkage!", &GV);