[llvm-commits] CVS: llvm/tools/bugpoint/BugDriver.h CodeGeneratorBug.cpp CrashDebugger.cpp ExtractFunction.cpp

[Chris Lattner]

Changes in directory llvm/tools/bugpoint:

BugDriver.h updated: 1.20 -> 1.21
CodeGeneratorBug.cpp updated: 1.30 -> 1.31
CrashDebugger.cpp updated: 1.23 -> 1.24
ExtractFunction.cpp updated: 1.18 -> 1.19

---
Log message:

I hate it when bugpoint is all ready to give me a bytecode file, then crashes
in final cleanups.  Then you had to run the whole mess again with 
-disable-final-cleanups.

This makes bugpoint run the cleanups in a protected environment so that if
they crash, bugpoint itself doesn't crash.  This makes things much happier,
implements a FIXME, and gets rid of YABPO (yet another bugpoint option).



---
Diffs of the changes:  (+35 -25)

Index: llvm/tools/bugpoint/BugDriver.h
diff -u llvm/tools/bugpoint/BugDriver.h:1.20 llvm/tools/bugpoint/BugDriver.h:1.21
--- llvm/tools/bugpoint/BugDriver.h:1.20	Wed Nov  5 15:15:19 2003
+++ llvm/tools/bugpoint/BugDriver.h	Wed Nov  5 15:45:35 2003
@@ -120,7 +120,7 @@
 
 
   /// EmitProgressBytecode - This function is used to output the current Program
-  /// to a file named "bugpoing-ID.bc".
+  /// to a file named "bugpoint-ID.bc".
   ///
   void EmitProgressBytecode(const std::string &ID, bool NoFlyer = false);
   
@@ -162,7 +162,7 @@
   /// the MayModifySemantics argument is true, then the cleanups is allowed to
   /// modify how the code behaves.
   ///
-  void performFinalCleanups(Module *M, bool MayModifySemantics = false) const;
+  Module *performFinalCleanups(Module *M, bool MayModifySemantics = false);
 
   /// initializeExecutionEnvironment - This method is used to set up the
   /// environment for executing LLVM programs.


Index: llvm/tools/bugpoint/CodeGeneratorBug.cpp
diff -u llvm/tools/bugpoint/CodeGeneratorBug.cpp:1.30 llvm/tools/bugpoint/CodeGeneratorBug.cpp:1.31
--- llvm/tools/bugpoint/CodeGeneratorBug.cpp:1.30	Wed Nov  5 15:15:19 2003
+++ llvm/tools/bugpoint/CodeGeneratorBug.cpp	Wed Nov  5 15:45:35 2003
@@ -224,8 +224,8 @@
   }
 
   // Clean up the modules, removing extra cruft that we don't need anymore...
-  BD.performFinalCleanups(SafeModule);
-  BD.performFinalCleanups(TestModule);
+  SafeModule = BD.performFinalCleanups(SafeModule);
+  TestModule = BD.performFinalCleanups(TestModule);
 
   if (BD.writeProgramToFile(TestModuleBC, TestModule)) {
     std::cerr << "Error writing bytecode to `" << SafeModuleBC << "'\nExiting.";


Index: llvm/tools/bugpoint/CrashDebugger.cpp
diff -u llvm/tools/bugpoint/CrashDebugger.cpp:1.23 llvm/tools/bugpoint/CrashDebugger.cpp:1.24
--- llvm/tools/bugpoint/CrashDebugger.cpp:1.23	Wed Nov  5 15:15:19 2003
+++ llvm/tools/bugpoint/CrashDebugger.cpp	Wed Nov  5 15:45:35 2003
@@ -379,7 +379,7 @@
   // Try to clean up the testcase by running funcresolve and globaldce...
   std::cout << "\n*** Attempting to perform final cleanups: ";
   Module *M = CloneModule(Program);
-  performFinalCleanups(M, true);
+  M = performFinalCleanups(M, true);
   std::swap(Program, M);
             
   // Find out if the pass still crashes on the cleaned up program...


Index: llvm/tools/bugpoint/ExtractFunction.cpp
diff -u llvm/tools/bugpoint/ExtractFunction.cpp:1.18 llvm/tools/bugpoint/ExtractFunction.cpp:1.19
--- llvm/tools/bugpoint/ExtractFunction.cpp:1.18	Wed Nov  5 15:15:19 2003
+++ llvm/tools/bugpoint/ExtractFunction.cpp	Wed Nov  5 15:45:35 2003
@@ -37,9 +37,6 @@
   cl::opt<bool, true>
   NoSCFG("disable-simplifycfg", cl::location(DisableSimplifyCFG),
          cl::desc("Do not use the -simplifycfg pass to reduce testcases"));
-  cl::opt<bool>
-  NoFinalCleanup("disable-final-cleanup",
-                 cl::desc("Disable the final cleanup phase of narrowing"));
 }
 
 /// deleteInstructionFromProgram - This method clones the current Program and
@@ -89,29 +86,42 @@
   return Result;
 }
 
+static const PassInfo *getPI(Pass *P) {
+  const PassInfo *PI = P->getPassInfo();
+  delete P;
+  return PI;
+}
+
 /// performFinalCleanups - This method clones the current Program and performs
 /// a series of cleanups intended to get rid of extra cruft on the module
 /// before handing it to the user...
 ///
-void BugDriver::performFinalCleanups(Module *M, bool MayModifySemantics) const {
-  // Allow disabling these passes if they crash bugpoint.
-  //
-  // FIXME: This should eventually run these passes in a pass list to prevent
-  // them from being able to crash bugpoint at all!
-  //
-  if (NoFinalCleanup) return;
-
+Module *BugDriver::performFinalCleanups(Module *M, bool MayModifySemantics) {
   // Make all functions external, so GlobalDCE doesn't delete them...
   for (Module::iterator I = M->begin(), E = M->end(); I != E; ++I)
     I->setLinkage(GlobalValue::ExternalLinkage);
   
-  PassManager CleanupPasses;
-  // Make sure that the appropriate target data is always used...
-  CleanupPasses.add(new TargetData("bugpoint", M));
-  CleanupPasses.add(createFunctionResolvingPass());
-  CleanupPasses.add(createGlobalDCEPass());
-  CleanupPasses.add(createDeadTypeEliminationPass());
-  CleanupPasses.add(createDeadArgEliminationPass(MayModifySemantics));
-  CleanupPasses.add(createVerifierPass());
-  CleanupPasses.run(*M);
+  std::vector<const PassInfo*> CleanupPasses;
+  CleanupPasses.push_back(getPI(createFunctionResolvingPass()));
+  CleanupPasses.push_back(getPI(createGlobalDCEPass()));
+  CleanupPasses.push_back(getPI(createDeadTypeEliminationPass()));
+  CleanupPasses.push_back(getPI(createDeadArgHackingPass()));
+
+  std::swap(Program, M);
+  std::string Filename;
+  bool Failed = runPasses(CleanupPasses, Filename);
+  std::swap(Program, M);
+
+  if (Failed) {
+    std::cerr << "Final cleanups failed.  Sorry.  :(\n";
+  } else {
+    delete M;
+    M = ParseInputFile(Filename);
+    if (M == 0) {
+      std::cerr << getToolName() << ": Error reading bytecode file '"
+                << Filename << "'!\n";
+      exit(1);
+    }
+  }
+  return M;
 }