[llvm-commits] CVS: llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp

[Chris Lattner]

Changes in directory llvm/lib/Transforms/Utils:

PromoteMemoryToRegister.cpp updated: 1.45 -> 1.46

---
Log message:

The PhiNodes 2D vector is only used during PHI node placement.  It doesn't
need to be an instance variable!


---
Diffs of the changes:

Index: llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
diff -u llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp:1.45 llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp:1.46
--- llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp:1.45	Sat Oct  4 22:16:07 2003
+++ llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp	Sat Oct  4 22:26:25 2003
@@ -62,10 +62,6 @@
     // VersionNumbers - Current version counters for each alloca
     std::vector<unsigned> VersionNumbers;
     
-    // PhiNodes - Each alloca contains a list of basic blocks which contain PHI
-    // nodes for the alloca.
-    std::vector<std::vector<BasicBlock*> > PhiNodes;
-    
     // NewPhiNodes - The PhiNodes we're adding.
     std::map<BasicBlock*, std::vector<PHINode*> > NewPhiNodes;
 
@@ -90,7 +86,6 @@
   Function &F = *DF.getRoot()->getParent();
 
   VersionNumbers.resize(Allocas.size());
-  PhiNodes.resize(Allocas.size());
 
   for (unsigned i = 0; i != Allocas.size(); ++i) {
     AllocaInst *AI = Allocas[i];
@@ -110,6 +105,10 @@
 
     AllocaLookup[Allocas[i]] = i;
     
+    // PhiNodeBlocks - A list of blocks that phi nodes have been inserted for
+    // this alloca.
+    std::vector<BasicBlock*> PhiNodeBlocks;
+
     // Compute the locations where PhiNodes need to be inserted.  Look at the
     // dominance frontier of EACH basic-block we have a write in.
     //
@@ -120,19 +119,20 @@
         const DominanceFrontier::DomSetType &S = it->second;
         for (DominanceFrontier::DomSetType::iterator P = S.begin(),PE = S.end();
              P != PE; ++P)
-          QueuePhiNode(*P, i);
+          if (QueuePhiNode(*P, i))
+            PhiNodeBlocks.push_back(*P);
       }
     }
     
     // Perform iterative step
-    std::vector<BasicBlock*> &AllocaPhiNodes = PhiNodes[i];
-    for (unsigned k = 0; k != AllocaPhiNodes.size(); k++) {
-      DominanceFrontier::const_iterator it = DF.find(AllocaPhiNodes[k]);
+    for (unsigned k = 0; k != PhiNodeBlocks.size(); k++) {
+      DominanceFrontier::const_iterator it = DF.find(PhiNodeBlocks[k]);
       if (it != DF.end()) {
         const DominanceFrontier::DomSetType &S = it->second;
         for (DominanceFrontier::DomSetType::iterator
                P = S.begin(), PE = S.end(); P != PE; ++P)
-          QueuePhiNode(*P, i);
+          if (QueuePhiNode(*P, i))
+            PhiNodeBlocks.push_back(*P);
       }
     }
   }
@@ -198,7 +198,6 @@
     PN->addIncoming(NullVal, Preds[i]);
 
   BBPNs[AllocaNo] = PN;
-  PhiNodes[AllocaNo].push_back(BB);
   return true;
 }