[llvm-commits] CVS: llvm/lib/CodeGen/RegAlloc/PhyRegAlloc.cpp

Chris Lattner lattner at cs.uiuc.edu
Tue Aug 5 16:57:01 PDT 2003


Changes in directory llvm/lib/CodeGen/RegAlloc:

PhyRegAlloc.cpp updated: 1.101 -> 1.102

---
Log message:

Physical registers no longer live in the regsUsed set for each machine instr


---
Diffs of the changes:

Index: llvm/lib/CodeGen/RegAlloc/PhyRegAlloc.cpp
diff -u llvm/lib/CodeGen/RegAlloc/PhyRegAlloc.cpp:1.101 llvm/lib/CodeGen/RegAlloc/PhyRegAlloc.cpp:1.102
--- llvm/lib/CodeGen/RegAlloc/PhyRegAlloc.cpp:1.101	Tue Jul 29 14:49:21 2003
+++ llvm/lib/CodeGen/RegAlloc/PhyRegAlloc.cpp	Tue Aug  5 16:55:58 2003
@@ -1150,32 +1150,44 @@
 // instructions. Both explicit and implicit operands are set.
 //----------------------------------------------------------------------------
 
-void PhyRegAlloc::setRelRegsUsedByThisInst(RegClass *RC, 
-                                           const int RegType,
-                                           const MachineInstr *MInst )
+static void markRegisterUsed(int RegNo, RegClass *RC, int RegType,
+                             const TargetRegInfo &TRI) {
+  unsigned classId = 0;
+  int classRegNum = TRI.getClassRegNum(RegNo, classId);
+  if (RC->getID() == classId)
+    RC->markColorsUsed(classRegNum, RegType, RegType);
+}
+
+void PhyRegAlloc::setRelRegsUsedByThisInst(RegClass *RC, int RegType,
+                                           const MachineInstr *MI)
 {
-  assert(OperandsColoredMap[MInst] == true &&
+  assert(OperandsColoredMap[MI] == true &&
          "Illegal to call setRelRegsUsedByThisInst() until colored operands "
          "are marked for an instruction.");
 
-  // Add the registers already marked as used by the instruction. 
-  // This should include any scratch registers that are used to save
-  // values across the instruction (e.g., for saving state register values).
-  const std::set<int> &regsUsed = MInst->getRegsUsed();
-  for (std::set<int>::iterator I=regsUsed.begin(),E=regsUsed.end(); I != E; ++I)
-    {
-      int i = *I;
-      unsigned classId = 0;
-      int classRegNum = MRI.getClassRegNum(i, classId);
-      if (RC->getID() == classId)
-        RC->markColorsUsed(classRegNum, RegType, RegType);
-    }
+  // Add the registers already marked as used by the instruction.
+  for (unsigned i = 0, e = MI->getNumOperands(); i != e; ++i)
+    if (MI->getOperand(i).hasAllocatedReg())
+      markRegisterUsed(MI->getOperand(i).getAllocatedRegNum(), RC, RegType,MRI);
+
+  for (unsigned i = 0, e = MI->getNumImplicitRefs(); i != e; ++i)
+    if (MI->getImplicitOp(i).hasAllocatedReg())
+      markRegisterUsed(MI->getImplicitOp(i).getAllocatedRegNum(), RC,
+                       RegType,MRI);
+
+  // The getRegsUsed() method returns the set of scratch registers that are used
+  // to save values across the instruction (e.g., for saving state register
+  // values).
+  const std::set<int> &regsUsed = MI->getRegsUsed();
+  for (std::set<int>::iterator I = regsUsed.begin(),
+         E = regsUsed.end(); I != E; ++I)
+    markRegisterUsed(*I, RC, RegType, MRI);
 
   // If there are implicit references, mark their allocated regs as well
   // 
-  for (unsigned z=0; z < MInst->getNumImplicitRefs(); z++)
+  for (unsigned z=0; z < MI->getNumImplicitRefs(); z++)
     if (const LiveRange*
-        LRofImpRef = LRI.getLiveRangeForValue(MInst->getImplicitRef(z)))    
+        LRofImpRef = LRI.getLiveRangeForValue(MI->getImplicitRef(z)))    
       if (LRofImpRef->hasColor())
         // this implicit reference is in a LR that received a color
         RC->markColorsUsed(LRofImpRef->getColor(),





More information about the llvm-commits mailing list