[llvm-commits] CVS: llvm/include/llvm/Analysis/DSNode.h DSSupport.h

Misha Brukman brukman at neo.cs.uiuc.edu
Sat Nov 2 15:19:00 PST 2002


Changes in directory llvm/include/llvm/Analysis:

DSNode.h updated: 1.4 -> 1.5
DSSupport.h updated: 1.1 -> 1.2

---
Log message:

Fixed comment on top of DSNode.h, added note to DSSupport.h as to why
functions were split out from DSNode class.


---
Diffs of the changes:

Index: llvm/include/llvm/Analysis/DSNode.h
diff -u llvm/include/llvm/Analysis/DSNode.h:1.4 llvm/include/llvm/Analysis/DSNode.h:1.5
--- llvm/include/llvm/Analysis/DSNode.h:1.4	Fri Nov  1 18:36:03 2002
+++ llvm/include/llvm/Analysis/DSNode.h	Sat Nov  2 15:18:53 2002
@@ -1,6 +1,6 @@
-//===- DSSupport.h - Support for datastructure graphs -----------*- C++ -*-===//
+//===- DSNode.h - Node definition for datastructure graphs ------*- C++ -*-===//
 //
-// Support for graph nodes, call sites, and types.
+// Data structure graph nodes and some implementation of DSNodeHandle.
 //
 //===----------------------------------------------------------------------===//
 


Index: llvm/include/llvm/Analysis/DSSupport.h
diff -u llvm/include/llvm/Analysis/DSSupport.h:1.1 llvm/include/llvm/Analysis/DSSupport.h:1.2
--- llvm/include/llvm/Analysis/DSSupport.h:1.1	Thu Oct 31 00:34:18 2002
+++ llvm/include/llvm/Analysis/DSSupport.h	Sat Nov  2 15:18:53 2002
@@ -28,6 +28,10 @@
 /// graph from getting out of date.  This class represents a "pointer" in the
 /// graph, whose destination is an indexed offset into a node.
 ///
+/// Note: some functions that are marked as inline in DSNodeHandle are actually
+/// defined in DSNode.h because they need knowledge of DSNode operation. Putting
+/// them in a CPP file wouldn't help making them inlined and keeping DSNode and
+/// DSNodeHandle (and friends) in one file complicates things.
 class DSNodeHandle {
   DSNode *N;
   unsigned Offset;





More information about the llvm-commits mailing list