[llvm-commits] CVS: llvm/lib/Reoptimizer/Mapping/getLLVMinfo.cpp

Misha Brukman brukman at cs.uiuc.edu
Wed Sep 11 17:58:00 PDT 2002

On Wed, 11 Sep 2002, Chris Lattner wrote:
> A comment (and I know that this has nothing to do with YOUR checkin): Most
> of these #includes are redundant.  You can probably get away with just:
> #include "llvm/Module.h"
> #include "Support/DataTypes.h"
> #include <map>
> Because Module includes Function, Function.h includes BasicBlock.h,
> BasicBlock.h includes Instruction.h etc.
> If you could, please prune these #includes if you get a chance...

Would it make sense to do this on a larger scale? There are a couple files
that include both Module and Function, for instance.

On the other hand, each file lists what it uses, and if anytime something
is refactored, it'll lead to a lot of broken code (correct me if I'm


More information about the llvm-commits mailing list