[llvm-bugs] [Bug 36230] New: [clang-format] formatting of td files

via llvm-bugs llvm-bugs at lists.llvm.org
Sun Feb 4 08:10:22 PST 2018


https://bugs.llvm.org/show_bug.cgi?id=36230

            Bug ID: 36230
           Summary: [clang-format] formatting of td files
           Product: clang
           Version: trunk
          Hardware: PC
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: Formatter
          Assignee: unassignedclangbugs at nondot.org
          Reporter: marina.yatsina at intel.com
                CC: djasper at google.com, klimek at google.com,
                    llvm-bugs at lists.llvm.org

When applying clang-format on td files it outputs a not very readable format
for instruction definitions (and instruction patterns).

For example, the following:
clang-format llvm/lib/Target/X86/X86InstrMPX.td

Break the src and dst parameters and produces this kind of formatting:

multiclass mpx_bound_make<bits<8> opc, string OpcodeStr> {
  let mayLoad = 1 in {
    def 32rm : I<opc, MRMSrcMem,
                 (outs BNDR
                  : $dst),
                 (ins i32mem
                  : $src),
                 OpcodeStr #"\t{$src, $dst|$dst, $src}", []>,
               Requires<[ HasMPX, Not64BitMode ]>;
    def 64rm : RI<opc, MRMSrcMem,
                  (outs BNDR
                   : $dst),
                  (ins i64mem
                   : $src),
                  OpcodeStr #"\t{$src, $dst|$dst, $src}", []>,
               Requires<[ HasMPX, In64BitMode ]>;
  }
}

At the very least I would have expected that each variable (e.g. "(outs BNDR :
$dst)") be on the same line.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20180204/e355299f/attachment.html>


More information about the llvm-bugs mailing list