[llvm-bugs] [Bug 40190] New: When rewriting the `From:` email header, need to add real sender to `Reply-To:` header.

via llvm-bugs llvm-bugs at lists.llvm.org
Mon Dec 31 03:04:11 PST 2018


            Bug ID: 40190
           Summary: When rewriting the `From:` email header, need to add
                    real sender to `Reply-To:` header.
           Product: Phabricator
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: All Bugs
          Assignee: unassignedbugs at nondot.org
          Reporter: chandlerc at gmail.com
                CC: llvm-bugs at lists.llvm.org

When Phabricator is sending email on my behalf, it will rewrite the `From:`
header in order to avoid DMARC issues. This is good (if a frustrating

However, unlike the mailing lists, Phab does not take the original contents of
the `From:` header and put them into the `Reply-To:` header. This is bad for
many reasons. First, it makes it hard (impossible?) to reliably detect what
email address is associated with the sender. Second, replies may fail to
include the sender which is surprising.

Here is the doubly re-written `From:` header from one such phab update:
From: Chandler Carruth via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org>

And here is the `Reply-To:` header showing the original `Reply-To:` added by
Phab to capture responses, and the list has added Phab's `From:` into it, but
we have lost the original author email:
Reply-To: reviews+D56162+public+e080bc19d9bb39f5 at reviews.llvm.org, Chandler
Carruth via Phabricator <reviews at reviews.llvm.org>

You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20181231/a7e44cca/attachment.html>

More information about the llvm-bugs mailing list