[llvm-bugs] [Bug 37239] New: Lit line-number reporting (r330755) breaks on Windows/cmd.exe

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=37239

            Bug ID: 37239
           Summary: Lit line-number reporting (r330755) breaks on
                    Windows/cmd.exe
           Product: Test Suite
           Version: trunk
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: normal
          Priority: P
         Component: lit
          Assignee: unassignedbugs at nondot.org
          Reporter: jeremy.morse.llvm at gmail.com
                CC: daniel at zuster.org, llvm-bugs at lists.llvm.org

Hi,

r330755 introduces a feature in lit where the source "RUN" line number is
included in the failing command -- unfortunately this doesn't seem to work well
on Windows (10), and is breaking on a build bot [0]. Looking at the
shtest-run-at-line test, it recursively calls lit onto
utils/lit/tests/Inputs/shtest-run-at-line/external-shell/basic.txt. The batch
script generated for that test is:

--------8<--------
@echo off
: 'RUN: at line 1';  true
if %ERRORLEVEL% NEQ 0 EXIT
: 'RUN: at line 2';  false
if %ERRORLEVEL% NEQ 0 EXIT
: 'RUN: at line 3';  true
-------->8--------

Under unix shell, the ':' null command would just be discarded. cmd.exe however
interprets the whole line as a label [1], and none of the commands are ever
run.

[0] http://lab.llvm.org:8011/builders/clang-x64-ninja-win7
[1]
https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/goto

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20180425/e321b5db/attachment.html>