[llvm-bugs] [Bug 35061] New: [lldb] python scripts contain duplicated copies of basic utilities

via llvm-bugs llvm-bugs at lists.llvm.org
Tue Oct 24 09:38:23 PDT 2017


https://bugs.llvm.org/show_bug.cgi?id=35061

            Bug ID: 35061
           Summary: [lldb] python scripts contain duplicated copies of
                    basic utilities
           Product: lldb
           Version: unspecified
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: All Bugs
          Assignee: lldb-dev at lists.llvm.org
          Reporter: davide at freebsd.org
                CC: llvm-bugs at lists.llvm.org

Forked from the mailing list discussion. At least is_exe and which are repeated
many times (some of these  are symlinks).

[davide at cupiditate lldb]$ grep -R 'def is_exe' *
packages/Python/lldbsuite/test/dotest.py:def is_exe(fpath):
packages/Python/lldbsuite/test/lldbtest.py:def is_exe(fpath):
packages/Python/lldbsuite/test/benchmarks/disassembly/TestDisassembly.py:def
is_exe(fpath):
packages/Python/lldbsuite/test/lldbutil.py:def is_exe(fpath):
scripts/Xcode/build-llvm.py:def is_executable(path):
test/testcases/dotest.py:def is_exe(fpath):
test/testcases/lldbtest.py:def is_exe(fpath):
test/testcases/benchmarks/disassembly/TestDisassembly.py:def is_exe(fpath):
test/testcases/lldbutil.py:def is_exe(fpath):
utils/test/llvm-mc-shell.py:def is_exe(fpath):
utils/test/disasm.py:def is_exe(fpath):
utils/test/run-until-faulted.py:def is_exe(fpath):
utils/lui/lldbutil.py:def is_exe(fpath):
[davide at cupiditate lldb]$ grep -R 'def is_exe' * |wc -l
13

We should have a single implementation in utils/ and include it from
everywhere.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20171024/6bc64e63/attachment.html>


More information about the llvm-bugs mailing list