[llvm-bugs] [Bug 34996] New: Possible incorrect message in file "libcxx/include/list" line 484

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=34996

            Bug ID: 34996
           Summary: Possible incorrect message in file
                    "libcxx/include/list" line 484
           Product: libc++
           Version: unspecified
          Hardware: PC
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: All Bugs
          Assignee: unassignedclangbugs at nondot.org
          Reporter: petrum at gmail.com
                CC: llvm-bugs at lists.llvm.org, mclow.lists at gmail.com

While experimenting with a CodeSonar plugin we develop, we noticed a potential
bug in file "libcxx/include/list" line 484 (method
"__list_const_iterator::operator->()").

pointer operator->() const
{
#if _LIBCPP_DEBUG_LEVEL >= 2
        _LIBCPP_ASSERT(__get_const_db()->__dereferenceable(this),
                       "Attempted to dereference a non-dereferenceable
list::iterator"); //HERE
#endif
        return
pointer_traits<pointer>::pointer_to(__ptr_->__as_node()->__value_);
}

Shouldn't the string message be "Attempted to dereference a non-dereferenceable
list::const_iterator" instead of the current one? The operation is for a
const_iterator (being in class __list_const_iterator). Moreover, for operator*
the message also mentions a "const_" iterator.

Thanks,
Petru Florin Mihancea

Note: The problem has been detected automatically via static analysis.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20171019/c29c6095/attachment-0001.html>