[llvm-bugs] [Bug 35304] New: include/clang/Tooling/Refactoring/Rename/RenamingAction.h:79]: (performance)

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=35304

            Bug ID: 35304
           Summary: include/clang/Tooling/Refactoring/Rename/RenamingActio
                    n.h:79]: (performance)
           Product: new-bugs
           Version: trunk
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: new bugs
          Assignee: unassignedbugs at nondot.org
          Reporter: dcb314 at hotmail.com
                CC: llvm-bugs at lists.llvm.org

trunk/llvm/tools/clang/include/clang/Tooling/Refactoring/Rename/RenamingAction.h:79]:
(performance) Function parameter 'NewQualifiedName' should be passed by
reference.

Source code is

  QualifiedRenameRule(const NamedDecl *ND,
                      std::string NewQualifiedName)

Maybe better code

  QualifiedRenameRule(const NamedDecl *ND,
                      const std::string & NewQualifiedName)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20171114/36b4e984/attachment.html>