[llvm-bugs] [Bug 26125] Clang format creates unwanted temporary files when batching processing on windows

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=26125

Nico Weber <nicolasweber at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #5 from Nico Weber <nicolasweber at gmx.de> ---
Fix got reverted here:
http://llvm.org/viewvc/llvm-project?view=revision&revision=296237 with reason

"""

Revert r296166, "clang-format: Don't leave behind temp files in -i mode on
Windows, PR26125", and r296171.

(MemoryBuffer)Code.reset() was too early.

  ==26912== Invalid read of size 1
  ==26912==    at 0x437E1D: llvm::MemoryBuffer::init(char const*, char const*,
bool) (MemoryBuffer.cpp:47)
  ==26912==    by 0x438013: (anonymous
namespace)::MemoryBufferMem::MemoryBufferMem(llvm::StringRef, bool)
(MemoryBuffer.cpp:86)
  ==26912==    by 0x438128: llvm::MemoryBuffer::getMemBuffer(llvm::StringRef,
llvm::StringRef, bool) (MemoryBuffer.cpp:112)
  ==26912==    by 0x4E189D: clang::vfs::detail::(anonymous
namespace)::InMemoryFileAdaptor::getBuffer(llvm::Twine const&, long, bool,
bool) (VirtualFileSystem.cpp:443)
  ==26912==    by 0x4DF5BA:
clang::vfs::FileSystem::getBufferForFile(llvm::Twine const&, long, bool, bool)
(VirtualFileSystem.cpp:94)
  ==26912==    by 0x4B72EC:
clang::FileManager::getBufferForFile(clang::FileEntry const*, bool, bool)
(FileManager.cpp:443)
  ==26912==    by 0x4C1F81:
clang::SrcMgr::ContentCache::getBuffer(clang::DiagnosticsEngine&,
clang::SourceManager const&, clang::SourceLocation, bool*) const
(SourceManager.cpp:98)
  ==26912==    by 0x4C50E5: clang::SourceManager::getBufferData(clang::FileID,
bool*) const (SourceManager.cpp:689)
  ==26912==    by 0x58E794: clang::Rewriter::getEditBuffer(clang::FileID)
(Rewriter.cpp:230)
  ==26912==    by 0x407297: clang::format::format(llvm::StringRef)
(ClangFormat.cpp:311)
  ==26912==    by 0x4078D7: main (ClangFormat.cpp:363)
"""


http://llvm-cs.pcc.me.uk/tools/clang/lib/Rewrite/Rewriter.cpp#446 is what
writes the reformatted file, and AtomicallyMovedFile right above does the
actual work. Resetting the mapping at the start in that dtor would probably be
the right place.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20170226/f0924408/attachment.html>