[llvm-bugs] [Bug 34025] New: Backport SVN r309744 to 5.0

via llvm-bugs llvm-bugs at lists.llvm.org
Tue Aug 1 14:16:36 PDT 2017


https://bugs.llvm.org/show_bug.cgi?id=34025

            Bug ID: 34025
           Summary: Backport SVN r309744 to 5.0
           Product: libraries
           Version: 5.0
          Hardware: PC
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: Backend: AArch64
          Assignee: unassignedbugs at nondot.org
          Reporter: martin at martin.st
                CC: llvm-bugs at lists.llvm.org

Please backport r309744 ([AArch64] Rewrite stack frame handling for win64
vararg functions) to 5.0. This fixes another issue with the new win/arm64
calling convention - similar to the one in PR33920 that already was backported
(thanks!).

The rationale is the same as in that one: The support for targeting win/arm64
itself is still incomplete, but the calling convention handling in itself is
getting complete, and can be used by Wine for clang >= 5.0. (The code already
in 5.0 works for Wine for the codepaths I've tested so far, but this makes it
more correct, in case other, so far untested, functions are compiled
differently.)

This carries no regression risk as it only touches code in new codepaths that
aren't used before. Even though it renames a variable, it doesn't have any
practical effect on other targets than windows.

One of the touched files, test/CodeGen/AArch64/win64_vararg.ll, got another
change inbetween, in r309015 (just an added testcase) - the one to backport
should apply cleanly both with and without the updated test (and backporting
the test shouldn't hurt either if that's an option).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20170801/ebd52c0f/attachment.html>


More information about the llvm-bugs mailing list