[llvm-bugs] [Bug 28197] New: lld-link can't handle `#pragma comment(linker, "/SECTION:.hook, RWS")`

[via llvm-bugs]

https://llvm.org/bugs/show_bug.cgi?id=28197

            Bug ID: 28197
           Summary: lld-link can't handle `#pragma comment(linker,
                    "/SECTION:.hook,RWS")`
           Product: lld
           Version: unspecified
          Hardware: PC
                OS: All
            Status: NEW
          Severity: normal
          Priority: P
         Component: All Bugs
          Assignee: unassignedbugs at nondot.org
          Reporter: nicolasweber at gmx.de
                CC: llvm-bugs at lists.llvm.org
    Classification: Unclassified

Chromium added this code in a file [1]:

#pragma data_seg(".hook")
HHOOK hook = NULL;
bool hook_called = false;
#pragma data_seg()
#pragma comment(linker, "/SECTION:.hook,RWS")


lld-link doesn't like it:

FAILED: sbox_integration_test_hook_dll.dll
sbox_integration_test_hook_dll.dll.lib sbox_integration_test_hook_dll.dll.pdb 
C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests
environment.x86 True sbox_integration_test_hook_dll.dll
"C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper
environment.x86 False ..\..\third_party/llvm-build/Release+Asserts/bin/lld-link
/nologo /IMPLIB:sbox_integration_test_hook_dll.dll.lib /DLL
/OUT:sbox_integration_test_hook_dll.dll
@sbox_integration_test_hook_dll.dll.rsp" 2 mt.exe rc.exe
"obj\sandbox\sbox_integration_test_hook_dll.sbox_integration_test_hook_dll.dll.intermediate.manifest"
obj\sandbox\sbox_integration_test_hook_dll.sbox_integration_test_hook_dll.dll.generated.manifest
/SECTION: is not allowed in .drectve



1:
https://cs.chromium.org/chromium/src/sandbox/win/tests/integration_tests/hooking_dll.cc?rcl=0&l=24


As a result, all chromium lld-link bots are currently red.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20160620/753d7f2a/attachment.html>