[llvm-bugs] [Bug 28066] New: compiler-rt/test/profile/Inputs/instrprof-file_ex.c:48]: (style) Suspicious condition

via llvm-bugs llvm-bugs at lists.llvm.org
Thu Jun 9 02:07:09 PDT 2016


https://llvm.org/bugs/show_bug.cgi?id=28066

            Bug ID: 28066
           Summary: compiler-rt/test/profile/Inputs/instrprof-file_ex.c:48
                    ]: (style) Suspicious condition
           Product: new-bugs
           Version: trunk
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P
         Component: new bugs
          Assignee: unassignedbugs at nondot.org
          Reporter: dcb314 at hotmail.com
                CC: llvm-bugs at lists.llvm.org
    Classification: Unclassified

trunk/llvm/projects/compiler-rt/test/profile/Inputs/instrprof-file_ex.c:48]:
(style) Suspicious condition (assignment + comparison); Clarify expression with
parentheses.

Source code is

   if ((tid = waitpid(child[i], &child_status, 0) == -1))

Maybe better code

   if ((tid = waitpid(child[i], &child_status, 0)) == -1)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20160609/b2aa3260/attachment.html>


More information about the llvm-bugs mailing list