[llvm-bugs] [Bug 28654] New: git-clang-format doesn't detect changes when space in file path (patch included)

via llvm-bugs llvm-bugs at lists.llvm.org
Thu Jul 21 16:29:32 PDT 2016


https://llvm.org/bugs/show_bug.cgi?id=28654

            Bug ID: 28654
           Summary: git-clang-format doesn't detect changes when space in
                    file path (patch included)
           Product: clang
           Version: trunk
          Hardware: PC
                OS: All
            Status: NEW
          Severity: normal
          Priority: P
         Component: Formatter
          Assignee: unassignedclangbugs at nondot.org
          Reporter: michael.john.kirk at gmail.com
                CC: djasper at google.com, klimek at google.com,
                    llvm-bugs at lists.llvm.org
    Classification: Unclassified

Created attachment 16787
  --> https://llvm.org/bugs/attachment.cgi?id=16787&action=edit
Patch fix from my fork at
https://github.com/michaelkirk/clang/commit/4b8958c5d8337ad8b8052a237003a8ad8d6057c4.patch

git-clang-format was failing to format some of my modified files.

Inspecting the git-clang-format script, I was able to trace it to
"modified_files" including a trailing tab in the file name. e.g. "My
Directory/Foo.m\t", which was ignored on account of ".m\t" being an unknown
extension.

This *may* be because my directory structure includes a space. I *did* test
that the files were properly formatted when renaming "My Directory" to
"MyDirectory" but not when renaming it to "My Other Directory"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-bugs/attachments/20160721/1837077a/attachment.html>


More information about the llvm-bugs mailing list